Fix get_thresholds route argument handling#139
Open
aaronaco wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aaron A. <aaronacodev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the documented
GET /get_thresholdsendpoint so it no longer returns500 Internal Server Errorwhen called from Swagger UI.The route previously read
promptwhile Swagger documentsprompts, then passed raw Hugging Face API URL/header values intorecommendation_handler.get_thresholds(). That helper expects an embedding function as its third argument.Changes
promptsquery parameters from/get_thresholds400when prompt samples are missing or emptyrecommendation_handler.get_thresholds()promptsquery parameters/get_thresholdsTesting
Result:
Manual Swagger test:
Returned threshold JSON successfully:
{ "add_higher_threshold": 0.5, "add_lower_threshold": 0.5, "remove_higher_threshold": 0.5, "remove_lower_threshold": 0.3 }Issue
Fixes #138