perf: Improve ConstantVector hashing in OptimizedVectorHasher#2014
Open
yingsu00 wants to merge 1 commit into
Open
perf: Improve ConstantVector hashing in OptimizedVectorHasher#2014yingsu00 wants to merge 1 commit into
yingsu00 wants to merge 1 commit into
Conversation
After this change, OptimizedVectorHasherBenchmark shows 150x gain in hashing ConstantVectors than the legacy VectorHasher.
xin-zhang2
reviewed
May 14, 2026
| if (!decoded_.isConstantMapping()) { | ||
| return std::nullopt; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think we also need an early return when decoded_.size() == 0
xin-zhang2
reviewed
May 14, 2026
Member
xin-zhang2
left a comment
xin-zhang2
left a comment
There was a problem hiding this comment.
Looks good. The unit tests for ConstantVector are still using the hash function. Can you also update them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, OptimizedVectorHasherBenchmark shows 150x gain in hashing ConstantVectors than the legacy VectorHasher.