Skip to content

PEtab v2 import via amici#1634

Draft
dweindl wants to merge 5 commits intoICB-DCM:developfrom
dweindl:amici_petab_v2
Draft

PEtab v2 import via amici#1634
dweindl wants to merge 5 commits intoICB-DCM:developfrom
dweindl:amici_petab_v2

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Oct 29, 2025

Support for PEtab v2 problems via amici.

WIP

@dweindl dweindl self-assigned this Oct 29, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 26.06383% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.06%. Comparing base (c1a20d2) to head (5b88d1f).

Files with missing lines Patch % Lines
pypesto/petab/objective_creator.py 21.62% 58 Missing ⚠️
pypesto/objective/amici/amici_calculator.py 7.89% 35 Missing ⚠️
pypesto/petab/importer.py 39.53% 26 Missing ⚠️
pypesto/objective/amici/amici.py 26.92% 19 Missing ⚠️
pypesto/petab/util.py 85.71% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1634      +/-   ##
===========================================
- Coverage    83.84%   82.06%   -1.79%     
===========================================
  Files          164      164              
  Lines        14346    14524     +178     
===========================================
- Hits         12029    11919     -110     
- Misses        2317     2605     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added the enhancement New feature or request label Oct 29, 2025
@dweindl dweindl force-pushed the amici_petab_v2 branch 5 times, most recently from e02ee18 to fb8ee2c Compare November 5, 2025 11:51
@dweindl dweindl force-pushed the amici_petab_v2 branch 2 times, most recently from 848567d to 0d8d0d0 Compare March 4, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AMICI enhancement New feature or request PEtab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants