Skip to content

Commit 2bc1d39

Browse files
author
David Eberius
committed
Documentation and minor bug fixes.
Signed-off-by: David Eberius <deberius@vols.utk.edu>
1 parent 4b8f3e1 commit 2bc1d39

5 files changed

Lines changed: 257 additions & 172 deletions

File tree

ompi/runtime/ompi_mpi_params.c

Lines changed: 3 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,6 @@ bool ompi_async_mpi_finalize = false;
7575
uint32_t ompi_add_procs_cutoff = OMPI_ADD_PROCS_CUTOFF_DEFAULT;
7676
bool ompi_mpi_dynamics_enabled = true;
7777

78-
char *ompi_mpi_spc_attach_string = NULL;
79-
char *ompi_mpi_spc_xml_string = NULL;
80-
bool ompi_mpi_spc_dump_enabled = false;
81-
bool ompi_mpi_spc_mmap_enabled = false;
82-
int ompi_mpi_spc_snapshot_period = 0;
83-
int ompi_mpi_spc_p2p_message_boundary = 12288;
84-
int ompi_mpi_spc_collective_message_boundary = 12288;
85-
int ompi_mpi_spc_collective_comm_boundary = 64;
86-
8778
static bool show_default_mca_params = false;
8879
static bool show_file_mca_params = false;
8980
static bool show_enviro_mca_params = false;
@@ -330,61 +321,9 @@ int ompi_mpi_register_params(void)
330321
MCA_BASE_VAR_SYN_FLAG_DEPRECATED);
331322
}
332323

333-
ompi_mpi_spc_attach_string = NULL;
334-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_attach",
335-
"A comma delimeted string listing the software-based performance counters (SPCs) to enable.",
336-
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0,
337-
OPAL_INFO_LVL_4,
338-
MCA_BASE_VAR_SCOPE_READONLY,
339-
&ompi_mpi_spc_attach_string);
340-
341-
ompi_mpi_spc_xml_string = NULL;
342-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_xml_string",
343-
"A string to add to SPC XML files for easier identification. The format will be: spc_data.[nodename].[jobid or spc_xml_string].[world_rank].xml",
344-
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0,
345-
OPAL_INFO_LVL_4,
346-
MCA_BASE_VAR_SCOPE_READONLY,
347-
&ompi_mpi_spc_xml_string);
348-
349-
ompi_mpi_spc_dump_enabled = false;
350-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_dump_enabled",
351-
"A boolean value for whether (true) or not (false) to enable dumping SPC counters in MPI_Finalize.",
352-
MCA_BASE_VAR_TYPE_BOOL, NULL, 0, 0,
353-
OPAL_INFO_LVL_4,
354-
MCA_BASE_VAR_SCOPE_READONLY,
355-
&ompi_mpi_spc_dump_enabled);
356-
357-
ompi_mpi_spc_mmap_enabled = false;
358-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_mmap_enabled",
359-
"A boolean value for whether (true) or not (false) to enable dumping SPC counters to an mmap'd file.",
360-
MCA_BASE_VAR_TYPE_BOOL, NULL, 0, 0,
361-
OPAL_INFO_LVL_4,
362-
MCA_BASE_VAR_SCOPE_READONLY,
363-
&ompi_mpi_spc_mmap_enabled);
364-
365-
ompi_mpi_spc_p2p_message_boundary = 12288;
366-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_p2p_message_boundary",
367-
"An integer value for determining the boundary for whether a message is small/large for point to point message size bin counter (<= this value is small).",
368-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
369-
OPAL_INFO_LVL_4,
370-
MCA_BASE_VAR_SCOPE_READONLY,
371-
&ompi_mpi_spc_p2p_message_boundary);
372-
373-
ompi_mpi_spc_collective_message_boundary = 12288;
374-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_message_boundary",
375-
"An integer value for determining the boundary for whether a message is small/large for collective bin counters (<= this value is small).",
376-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
377-
OPAL_INFO_LVL_4,
378-
MCA_BASE_VAR_SCOPE_READONLY,
379-
&ompi_mpi_spc_collective_message_boundary);
380-
381-
ompi_mpi_spc_collective_comm_boundary = 64;
382-
(void) mca_base_var_register("ompi", "mpi", NULL, "spc_comm_boundary",
383-
"An integer value for determining the boundary for whether a communicator is small/large for collective bin counters (<= this value is small).",
384-
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
385-
OPAL_INFO_LVL_4,
386-
MCA_BASE_VAR_SCOPE_READONLY,
387-
&ompi_mpi_spc_collective_comm_boundary);
324+
#if SPC_ENABLE == 1
325+
(void) ompi_spc_register_params();
326+
#endif
388327

389328
return OMPI_SUCCESS;
390329
}

0 commit comments

Comments
 (0)