Skip to content

Compile fix for PS5 platform#36

Open
MicheleCaovilla wants to merge 1 commit into
IDI-Systems:masterfrom
MicheleCaovilla:master
Open

Compile fix for PS5 platform#36
MicheleCaovilla wants to merge 1 commit into
IDI-Systems:masterfrom
MicheleCaovilla:master

Conversation

@MicheleCaovilla

Copy link
Copy Markdown

Fix for issue #34 by Reply Game Studios

@jonpas

jonpas commented Jan 11, 2025

Copy link
Copy Markdown
Member

ImPlot changes should be made upstream.

@MicheleCaovilla

Copy link
Copy Markdown
Author

ImPlot changes should be made upstream.

Sorry, I rarely use git for public projects so I'm not a PR expert. What am I supposed to do? Pushing ImPlot changes to the ImPlot repo? Thanks

@jonpas

jonpas commented Jan 14, 2025

Copy link
Copy Markdown
Member

Yes, files in ThirdParty should not be specifically changed in this repo (except configuration).

However, PLATFORM_PS5 comes from Unreal, so it should not be used in those projects either. We should instead define something those projects expect to have defined to make those changes.

@MicheleCaovilla

Copy link
Copy Markdown
Author

Yes, files in ThirdParty should not be specifically changed in this repo (except configuration).

However, PLATFORM_PS5 comes from Unreal, so it should not be used in those projects either. We should instead define something those projects expect to have defined to make those changes.

Thanks for the explanation.

We could do something like #define IMGUI_DISABLE_DEFAULT_SHELL_FUNCTIONS in the ImGui file. I'll try to work on it over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants