Extensions - Add Tracy support#1215
Conversation
|
@jonpas I think this is now ready for review/merging. |
|
Self-note: Need to add that to docs and CI, as it's a new extension module. |
I don't think that's correct, did you mean Also can you submodule Tracy on a specific tag instead of a hard-to-find-version commit? As for CI, I don't think we need to add acre2/.github/workflows/release.yml Line 97 in eed3692 ACRE2Core like ACRE2Core itself gets pulled into other modules.
I do want to add profiling options to the docs though, if/when Mumble ever gets merged - or maybe cherry-picked out into the main branch at least. |
| @@ -0,0 +1,3 @@ | |||
| [submodule "extensions/src/ACRE2Profiling/tracy"] | |||
There was a problem hiding this comment.
instead of submodules maybe just use cmake fetch
include(FetchContent)
FetchContent_Declare(
tracy
GIT_REPOSITORY https://github.com/wolfpld/tracy
GIT_TAG v0.9.1
)
FetchContent_MakeAvailable(tracy)
When merged this pull request will:
-DUSE_TRACY=ONwhen calling cmake