Skip to content

Make add_artifact replace by name (#685) #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkanwar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make add_artifact replace by name (#685) #925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions sacred/observers/mongo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,14 @@ def resource_event(self, filename):
self.save()

def artifact_event(self, name, filename, metadata=None, content_type=None):
# Delete artifacts with the same name, collect the rest
artifacts = []
for entry in self.run_entry["artifacts"]:
if entry['name'] == name:
self.fs.delete(entry['file_id'])
else:
artifacts.append(entry)
# Create artifact
with open(filename, "rb") as f:
run_id = self.run_entry["_id"]
db_filename = "artifact://{}/{}/{}".format(self.runs.name, run_id, name)
Expand All @@ -308,8 +316,9 @@ def artifact_event(self, name, filename, metadata=None, content_type=None):
file_id = self.fs.put(
f, filename=db_filename, metadata=metadata, content_type=content_type
)

self.run_entry["artifacts"].append({"name": name, "file_id": file_id})
# Update artifacts list
artifacts.append({"name": name, "file_id": file_id})
self.run_entry["artifacts"] = artifacts
self.save()

@staticmethod
Expand Down