fix(eap): Replace update checklist file to EAPFile

Author: susilnem

eap/migrations/0011_alter_fulleap_updated_checklist_file_and_more.py

@@ -0,0 +1,35 @@
+# Generated by Django 4.2.26 on 2025-12-15 06:33
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("eap", "0010_eapaction_eapimpact_indicator_and_more"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="fulleap",
+            name="updated_checklist_file",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                to="eap.eapfile",
+                verbose_name="Updated Review Checklist File",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="simplifiedeap",
+            name="updated_checklist_file",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                to="eap.eapfile",
+                verbose_name="Updated Review Checklist File",
+            ),
+        ),
+    ]

eap/models.py

@@ -879,9 +879,10 @@ class CommonEAPFields(models.Model):
     )
 
     # Review Checklist
-    updated_checklist_file = SecureFileField(
-        verbose_name=_("Updated Checklist File"),
-        upload_to="eap/files/",
+    updated_checklist_file = models.ForeignKey[EAPFile | None, EAPFile | None](
+        EAPFile,
+        on_delete=models.SET_NULL,
+        verbose_name=_("Updated Review Checklist File"),
         null=True,
         blank=True,
     )

eap/serializers.py

@@ -427,8 +427,8 @@ def validate_updated_checklist_file(self, file):
         if file is None:
             return
 
-        validate_file_extention(file.name, ALLOWED_FILE_EXTENTIONS)
-        validate_file_type(file)
+        validate_file_extention(file.file.name, ALLOWED_FILE_EXTENTIONS)
+        validate_file_type(file.file)
         return file
 
     def validate_images_field(self, field_name, images):

eap/test_views.py

@@ -1245,7 +1245,7 @@ def test_status_transition(self):
             )
             # Snapshot Shouldn't have the updated checklist file
             self.assertFalse(
-                second_snapshot.updated_checklist_file.name,
+                second_snapshot.updated_checklist_file,
                 "Latest Snapshot shouldn't have the updated checklist file.",
             )
             # Check if the latest_simplified_eap is updated in EAPRegistration
@@ -1268,14 +1268,18 @@ def test_status_transition(self):
         # Upload updated checklist file
         # UPDATES on the second snapshot
         url = f"/api/v2/simplified-eap/{second_snapshot.id}/"
-        with tempfile.NamedTemporaryFile(suffix=".xlsx") as tmp_file:
-            tmp_file.write(b"Updated Test content")
-            tmp_file.seek(0)
-
-            file_data = {"eap_registration": second_snapshot.eap_registration_id, "updated_checklist_file": tmp_file}
+        checklist_file_instance = EAPFileFactory._create_file(
+            created_by=self.country_admin,
+            modified_by=self.country_admin,
+        )
+        file_data = {
+            "prioritized_hazard_and_impact": "Floods with potential heavy impact.",
+            "eap_registration": second_snapshot.eap_registration_id,
+            "updated_checklist_file": checklist_file_instance.id,
+        }
 
-            response = self.client.patch(url, file_data, format="multipart")
-            self.assertEqual(response.status_code, 200, response.data)
+        response = self.client.patch(url, file_data, format="json")
+        self.assertEqual(response.status_code, 200, response.data)
 
         # SUCCESS:
         self.authenticate(self.country_admin)
@@ -1336,7 +1340,7 @@ def test_status_transition(self):
             self.assertTrue(second_snapshot.is_locked)
             # Snapshot Shouldn't have the updated checklist file
             self.assertFalse(
-                third_snapshot.updated_checklist_file.name,
+                third_snapshot.updated_checklist_file,
                 "Latest snapshot shouldn't have the updated checklist file.",
             )
 
@@ -1356,14 +1360,17 @@ def test_status_transition(self):
         # Upload updated checklist file
         # UPDATES on the second snapshot
         url = f"/api/v2/simplified-eap/{third_snapshot.id}/"
-        with tempfile.NamedTemporaryFile(suffix=".xlsx") as tmp_file:
-            tmp_file.write(b"Updated Test content")
-            tmp_file.seek(0)
-
-            file_data = {"eap_registration": third_snapshot.eap_registration_id, "updated_checklist_file": tmp_file}
+        file_data = {
+            "prioritized_hazard_and_impact": "Floods with potential heavy impact.",
+            "risks_selected_protocols": "Protocol A and Protocol B.",
+            "selected_early_actions": "The early actions selected.",
+            "overall_objective_intervention": "To reduce risks through early actions.",
+            "eap_registration": third_snapshot.eap_registration_id,
+            "updated_checklist_file": checklist_file_instance.id,
+        }
 
-            response = self.client.patch(url, file_data, format="multipart")
-            self.assertEqual(response.status_code, 200)
+        response = self.client.patch(url, file_data, format="json")
+        self.assertEqual(response.status_code, 200)
 
         # SUCCESS:
         self.authenticate(self.country_admin)
@@ -1444,7 +1451,7 @@ def test_status_transition(self):
             self.assertTrue(third_snapshot.is_locked)
             # Snapshot Shouldn't have the updated checklist file
             self.assertFalse(
-                fourth_snapshot.updated_checklist_file.name,
+                fourth_snapshot.updated_checklist_file,
                 "Latest snapshot shouldn't have the updated checklist file.",
             )
 
@@ -1466,21 +1473,17 @@ def test_status_transition(self):
         # Upload updated checklist file
         # UPDATES on the second snapshot
         url = f"/api/v2/simplified-eap/{fourth_snapshot.id}/"
-        with tempfile.NamedTemporaryFile(suffix=".xlsx") as tmp_file:
-            tmp_file.write(b"Updated Test content")
-            tmp_file.seek(0)
+        file_data = {
+            "prioritized_hazard_and_impact": "Floods with potential heavy impact.",
+            "risks_selected_protocols": "Protocol A and Protocol B.",
+            "selected_early_actions": "The early actions selected.",
+            "overall_objective_intervention": "To reduce risks through early actions.",
+            "eap_registration": third_snapshot.eap_registration_id,
+            "updated_checklist_file": checklist_file_instance.id,
+        }
 
-            file_data = {
-                "prioritized_hazard_and_impact": "Floods with potential heavy impact.",
-                "risks_selected_protocols": "Protocol A and Protocol B.",
-                "selected_early_actions": "The early actions selected.",
-                "overall_objective_intervention": "To reduce risks through early actions.",
-                "eap_registration": third_snapshot.eap_registration_id,
-                "updated_checklist_file": tmp_file,
-            }
-
-            response = self.client.patch(url, file_data, format="multipart")
-            self.assertEqual(response.status_code, 200)
+        response = self.client.patch(url, file_data, format="json")
+        self.assertEqual(response.status_code, 200)
 
         # SUCCESS:
         self.authenticate(self.country_admin)