Merge pull request #2694 from IFRCGo/fix/dref-activities-translation

Lang/Fix translation cache duplicate creation issue

Author: szabozoltan69

assets

@@ -65,7 +65,7 @@ class Meta:
         fields = "__all__"
 
 
-class ProposedActionActivitySerializer(serializers.ModelSerializer):
+class ProposedActionActivitySerializer(ModelSerializer):
     id = serializers.IntegerField(required=False)
     sector = serializers.PrimaryKeyRelatedField(queryset=Sector.objects.all(), required=True)
 

dref/serializers.py

@@ -17,6 +17,7 @@
     PlannedIntervention,
     PlannedInterventionIndicators,
     ProposedAction,
+    ProposedActionActivities,
     RiskSecurity,
     SourceInformation,
 )
@@ -50,6 +51,7 @@ def send_dref_email(dref_id, users_emails, new_or_updated=""):
     PlannedIntervention,
     RiskSecurity,
     ProposedAction,
+    ProposedActionActivities,
     PlannedInterventionIndicators,
     SourceInformation,
 ]

dref/tasks.py

@@ -182,15 +182,22 @@ def translate_text(self, text, dest_language, source_language=None, table_field=
 
             # Cache the translation if original text was short enough
             if use_cache:
-                TranslationCache.objects.create(
+                obj, created = TranslationCache.objects.get_or_create(
                     text=text,
                     text_hash=text_hash,
                     source_language=source_language or "",  # source_language can be "detected"
                     dest_language=dest_language,
-                    translated_text=translated,
-                    table_field=table_field or "",
-                    last_used=timezone.now(),
+                    defaults={
+                        "translated_text": translated,
+                        "table_field": table_field or "",
+                        "last_used": timezone.now(),
+                    },
                 )
+                if not created:
+                    TranslationCache.objects.filter(pk=obj.pk).update(
+                        last_used=timezone.now(),
+                        num_calls=F("num_calls") + 1,
+                    )
             return translated + textTail