feat(eap): update schema on updating eap file instance

- update image field names on simplifiedeap

Author: susilnem

eap/admin.py

@@ -64,9 +64,9 @@ class SimplifiedEAPAdmin(admin.ModelAdmin):
     )
     readonly_fields = (
         "cover_image",
-        "hazard_impact_file",
-        "risk_selected_protocols_file",
-        "selected_early_actions_file",
+        "hazard_impact_images",
+        "risk_selected_protocols_images",
+        "selected_early_actions_images",
         "planned_operations",
         "enable_approaches",
         "parent",

eap/migrations/0008_remove_simplifiedeap_hazard_impact_file_and_more.py

@@ -0,0 +1,54 @@
+# Generated by Django 4.2.19 on 2025-11-25 10:51
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("eap", "0007_alter_eapfile_options_alter_eapregistration_options_and_more"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="simplifiedeap",
+            name="hazard_impact_file",
+        ),
+        migrations.RemoveField(
+            model_name="simplifiedeap",
+            name="risk_selected_protocols_file",
+        ),
+        migrations.RemoveField(
+            model_name="simplifiedeap",
+            name="selected_early_actions_file",
+        ),
+        migrations.AddField(
+            model_name="simplifiedeap",
+            name="hazard_impact_images",
+            field=models.ManyToManyField(
+                blank=True,
+                related_name="simplified_eap_hazard_impact_images",
+                to="eap.eapfile",
+                verbose_name="Hazard Impact Images",
+            ),
+        ),
+        migrations.AddField(
+            model_name="simplifiedeap",
+            name="risk_selected_protocols_images",
+            field=models.ManyToManyField(
+                blank=True,
+                related_name="simplified_eap_risk_selected_protocols_images",
+                to="eap.eapfile",
+                verbose_name="Risk Selected Protocols Images",
+            ),
+        ),
+        migrations.AddField(
+            model_name="simplifiedeap",
+            name="selected_early_actions_images",
+            field=models.ManyToManyField(
+                blank=True,
+                related_name="simplified_eap_selected_early_actions_images",
+                to="eap.eapfile",
+                verbose_name="Selected Early Actions Images",
+            ),
+        ),
+    ]

eap/models.py

@@ -796,10 +796,10 @@ class SimplifiedEAP(EAPBaseModel):
         null=True,
         blank=True,
     )
-    hazard_impact_file = models.ManyToManyField(
+    hazard_impact_images = models.ManyToManyField(
         EAPFile,
-        verbose_name=_("Hazard Impact Files"),
-        related_name="simplified_eap_hazard_impact_files",
+        verbose_name=_("Hazard Impact Images"),
+        related_name="simplified_eap_hazard_impact_images",
         blank=True,
     )
 
@@ -809,10 +809,10 @@ class SimplifiedEAP(EAPBaseModel):
         blank=True,
     )
 
-    risk_selected_protocols_file = models.ManyToManyField(
+    risk_selected_protocols_images = models.ManyToManyField(
         EAPFile,
-        verbose_name=_("Risk Selected Protocols Files"),
-        related_name="simplified_eap_risk_selected_protocols_files",
+        verbose_name=_("Risk Selected Protocols Images"),
+        related_name="simplified_eap_risk_selected_protocols_images",
         blank=True,
     )
 
@@ -822,10 +822,10 @@ class SimplifiedEAP(EAPBaseModel):
         null=True,
         blank=True,
     )
-    selected_early_actions_file = models.ManyToManyField(
+    selected_early_actions_images = models.ManyToManyField(
         EAPFile,
-        verbose_name=_("Selected Early Actions Files"),
-        related_name="simplified_eap_selected_early_actions_files",
+        verbose_name=_("Selected Early Actions Images"),
+        related_name="simplified_eap_selected_early_actions_images",
         blank=True,
     )
 

eap/serializers.py

@@ -193,6 +193,24 @@ def validate_file(self, file):
         return file
 
 
+# NOTE: Separate serializer for partial updating EAPFile instance
+class EAPFileUpdateSerializer(BaseEAPSerializer):
+    id = serializers.IntegerField(required=True)
+    file = serializers.FileField(required=False)
+
+    class Meta:
+        model = EAPFile
+        fields = "__all__"
+        read_only_fields = (
+            "created_by",
+            "modified_by",
+        )
+
+    def validate_file(self, file):
+        validate_file_type(file)
+        return file
+
+
 ALLOWED_MAP_TIMEFRAMES_VALUE = {
     OperationActivity.TimeFrame.YEARS: list(OperationActivity.YearsTimeFrameChoices.values),
     OperationActivity.TimeFrame.MONTHS: list(OperationActivity.MonthsTimeFrameChoices.values),
@@ -286,35 +304,35 @@ class SimplifiedEAPSerializer(
     enable_approaches = EnableApproachSerializer(many=True, required=False)
 
     # FILES
-    cover_image_details = EAPFileSerializer(source="cover_image", read_only=True)
-    hazard_impact_file_details = EAPFileSerializer(source="hazard_impact_file", many=True, read_only=True)
-    selected_early_actions_file_details = EAPFileSerializer(source="selected_early_actions_file", many=True, read_only=True)
-    risk_selected_protocols_file_details = EAPFileSerializer(source="risk_selected_protocols_file", many=True, read_only=True)
+    cover_image_file = EAPFileUpdateSerializer(source="cover_image", required=False, allow_null=True)
+    hazard_impact_images_details = EAPFileSerializer(source="hazard_impact_images", many=True, read_only=True)
+    selected_early_actions_file_details = EAPFileSerializer(source="selected_early_actions_images", many=True, read_only=True)
+    risk_selected_protocols_file_details = EAPFileSerializer(source="risk_selected_protocols_images", many=True, read_only=True)
 
     # Admin2
     admin2_details = Admin2Serializer(source="admin2", many=True, read_only=True)
 
     class Meta:
         model = SimplifiedEAP
-        fields = "__all__"
         read_only_fields = [
             "version",
             "is_locked",
         ]
+        exclude = ("cover_image",)
 
-    def validate_hazard_impact_file(self, images):
+    def validate_hazard_impact_images(self, images):
         if images and len(images) > self.MAX_NUMBER_OF_IMAGES:
             raise serializers.ValidationError(f"Maximum {self.MAX_NUMBER_OF_IMAGES} images are allowed to upload.")
         validate_file_type(images)
         return images
 
-    def validate_risk_selected_protocols_file(self, images):
+    def validate_risk_selected_protocols_images(self, images):
         if images and len(images) > self.MAX_NUMBER_OF_IMAGES:
             raise serializers.ValidationError(f"Maximum {self.MAX_NUMBER_OF_IMAGES} images are allowed to upload.")
         validate_file_type(images)
         return images
 
-    def validate_selected_early_actions_file(self, images):
+    def validate_selected_early_actions_images(self, images):
         if images and len(images) > self.MAX_NUMBER_OF_IMAGES:
             raise serializers.ValidationError(f"Maximum {self.MAX_NUMBER_OF_IMAGES} images are allowed to upload.")
         validate_file_type(images)

eap/views.py

@@ -160,10 +160,9 @@ def get_queryset(self) -> QuerySet[SimplifiedEAP]:
             .prefetch_related(
                 "eap_registration__partners",
                 "admin2",
-                "hazard_impact_file",
-                "selected_early_actions_file",
-                "risk_selected_protocols_file",
-                "selected_early_actions_file",
+                "hazard_impact_images",
+                "risk_selected_protocols_images",
+                "selected_early_actions_images",
                 "planned_operations",
                 "enable_approaches",
             )