fix(eap): implement feedback changes in eap sections and forms

    - update strings throughout the EAP sections and forms
    - add missing required validation in form schema
    - Update total budget in full EAP from NumberInput to TextOutput

Author: shreeyash07

app/src/views/AccountMyFormsEap/EapTableActions/i18n.json

@@ -5,12 +5,12 @@
         "startSimplifiedEapLinkLabel": "Start sEAP",
         "editFullEapLinkLabel": "Edit Full EAP",
         "viewFullEapLinkLabel": "View Full EAP",
-        "exportWithChangesButtonLabel": "Export with changes",
+        "exportWithChangesButtonLabel": "Export with track changes",
         "exportButtonLabel": "Export",
         "exportSummaryButtonLabel": "Export Summary",
         "previewExportLinkLabel": "Preview export",
         "previewSummaryExportLinkLabel": "Preview summary export",
-        "downloadReviewChecklistLinkLabel": "Download review checklist",
+        "downloadReviewChecklistLinkLabel": "Download Review checklist",
         "downloadUpdatedChecklistLinkLabel": "Download updated checklist",
         "editSimplifiedEapLinkLabel": "Edit sEAP",
         "viewSimplifiedEapLinkLabel": "View sEAP",

app/src/views/AccountMyFormsLayout/i18n.json

@@ -3,8 +3,8 @@
     "strings": {
         "fieldReportTabTitle": "Field Report",
         "perTabTitle": "PER",
-        "drefTabTitle": "DREF",
+        "drefTabTitle": "DREF Applications",
         "threeWTabTitle": "3W",
         "eapApplications": "EAP Applications"
     }
-}
+}

app/src/views/EapFullForm/FinanceLogistics/index.tsx

@@ -29,6 +29,7 @@ import { type PartialEapFullFormType } from '../schema';
 import SectionQualityCriteria from '../SectionQualityCriteria';
 
 import i18n from './i18n.json';
+import NonFieldError from '#components/NonFieldError';
 
 interface Props {
     value: PartialEapFullFormType;
@@ -162,15 +163,14 @@ function FinanceLogistics(props: Props) {
                         )}
                         withAsteriskOnTitle
                     >
-                        <NumberInput
+                        <TextOutput
+                            valueType="number"
+                            strongLabel
                             label={strings.financeTotalBudgetLabel}
-                            name="total_budget"
                             value={value.total_budget}
+                        />
+                        <NonFieldError
                             error={error?.total_budget}
-                            onChange={setFieldValue}
-                            disabled={disabled}
-                            readOnly
-                            required
                         />
                         <TextArea
                             label={strings.financeDescriptionLabel}

app/src/views/EapFullForm/Overview/KeyActorsInput/index.tsx

@@ -97,6 +97,7 @@ function KeyActorsInput(props: Props) {
                     />
                     <TextArea
                         label={strings.overviewKeyActorsDescriptionLabel}
+                        error={error?.description}
                         name="description"
                         value={value?.description}
                         onChange={onFieldChange}

app/src/views/EapFullForm/SelectionActions/OperationInput/index.tsx

@@ -87,6 +87,7 @@ function OperationsInput(props: Props) {
                     numPreferredGridColumns={3}
                 >
                     <NumberInput
+                        required
                         label={strings.selectionActionsPlannedOperationPeopleTargeted}
                         name="people_targeted"
                         value={value?.people_targeted}
@@ -96,6 +97,7 @@ function OperationsInput(props: Props) {
                         readOnly={readOnly}
                     />
                     <NumberInput
+                        required
                         label={strings.selectionActionsPlannedOperationBudget}
                         name="budget_per_sector"
                         value={value?.budget_per_sector}
@@ -105,6 +107,7 @@ function OperationsInput(props: Props) {
                         readOnly={readOnly}
                     />
                     <NumberInput
+                        required
                         label={strings.selectionActionsPlannedOperationApCode}
                         name="ap_code"
                         value={value?.ap_code}

app/src/views/EapFullForm/TriggerModel/i18n.json

@@ -15,7 +15,7 @@
         "sourcesForecastDescription": "Add respective source(s) for the forecast and the link to the website, if applicable.",
         "forecastExplanatoryNote": "In order for the DREF to approve funding when a trigger occurs, there must be a certain probability the extreme event will take place. To safeguard this, it is crucial to select those forecasts that have a certain “skill” level (certain level of confidence). If observations are used, these can also be included in the table. Note that this information does not need to be calculated by the National Society but can be obtained by working with hydro-meteorological services, research institutions, experts etc.",
         "forecastSelectionTitle": "Forecast selection",
-        "downloadForecastTableLabel": "Download Forecast table",
+        "downloadForecastTableLabel": "Download Menu of Forecast",
         "forecastRequiredPoint1": "State clearly which forecast(s) and observations will be used and why they were chosen.",
         "forecastRequiredPoint2": "Include a table with all available forecasts for your hazard. The table must include: Name of forecast, Lead time, Source, False Alarm Ratio, Number of times the forecast has been issued for this hazard in the last 10 years ",
         "forecastSelectionDescription": "State clearly which forecast(s) and observations will be used and why they were chosen. Include a table with all available forecasts for your hazard. The table must include: Name of forecast, Lead time, Source, False Alarm Ratio, Number of times the forecast has been issued for this hazard in the last 10 years.",

app/src/views/EapFullForm/index.tsx

@@ -343,6 +343,12 @@ export function Component() {
                         return formValue?.cover_image_file?.client_id;
                     }
 
+                    match = matchArray(locations, ['key_actors', NUM]);
+                    if (isDefined(match)) {
+                        const [index] = match;
+                        return formValue?.key_actors?.[index!]?.client_id;
+                    }
+
                     match = matchArray(locations, ['partner_contacts', NUM]);
                     if (isDefined(match)) {
                         const [index] = match;
@@ -1075,6 +1081,7 @@ export function Component() {
                                 name={undefined}
                                 onClick={handleRequestForApprovalButtonClick}
                                 disabled={readOnly}
+                                styleVariant="filled"
                             >
                                 {strings.submitButtonLabel}
                             </Button>

app/src/views/EapFullForm/schema.ts

@@ -6,11 +6,13 @@ import {
 import {
     addCondition,
     emailCondition,
+    lessThanOrEqualToCondition,
     type LiteralSchema,
     nullValue,
     type ObjectSchema,
     type PartialForm,
     type PurgeNull,
+    requiredListCondition,
     requiredStringCondition,
     undefinedValue,
     urlCondition,
@@ -632,6 +634,8 @@ export const formSchema: EapFullFormSchema = {
             },
 
             key_actors: {
+                required: isSubmit,
+                validation: requiredListCondition,
                 keySelector: (item) => item.client_id,
                 member: () => ({
                     fields: (): KeyActorsFormFields => ({
@@ -911,8 +915,12 @@ export const formSchema: EapFullFormSchema = {
                     fields: (): PlannedOperationalFields => ({
                         id: { defaultValue: undefinedValue },
                         sector: {},
-                        budget_per_sector: {},
-                        ap_code: {},
+                        budget_per_sector: {
+                            required: isSubmit,
+                        },
+                        ap_code: {
+                            required: isSubmit,
+                        },
                         indicators: {
                             keySelector: (indicator) => indicator.client_id,
                             member: () => indicatorSchema,
@@ -963,8 +971,12 @@ export const formSchema: EapFullFormSchema = {
                     fields: (): EnableApproachesFields => ({
                         id: { defaultValue: undefinedValue },
                         approach: {},
-                        budget_per_approach: {},
-                        ap_code: {},
+                        budget_per_approach: {
+                            required: isSubmit,
+                        },
+                        ap_code: {
+                            required: isSubmit,
+                        },
                         indicators: {
                             keySelector: (indicator) => indicator.client_id,
                             member: () => indicatorSchema,
@@ -1059,6 +1071,7 @@ export const formSchema: EapFullFormSchema = {
             people_targeted: {
                 required: isSubmit,
                 validations: [
+                    lessThanOrEqualToCondition(10000),
                     positiveIntegerCondition,
                 ],
             },

app/src/views/EapSimplifiedForm/RiskAnalysis/index.tsx

@@ -201,7 +201,7 @@ function RiskAnalysis(props: Props) {
                             error={error?.prioritized_hazard_and_impact}
                             disabled={disabled}
                             readOnly={readOnly}
-                            maxLength={charLimits.pre_positioning_budget}
+                            maxLength={charLimits.prioritized_hazard_and_impact}
                         />
                         <MultiImageWithCaptionInput
                             name="hazard_impact_images"

app/src/views/EapSimplifiedForm/schema.ts

@@ -5,6 +5,7 @@ import {
 } from '@togglecorp/fujs';
 import {
     emailCondition,
+    lessThanOrEqualToCondition,
     type LiteralSchema,
     type ObjectSchema,
     type PartialForm,
@@ -16,6 +17,7 @@ import {
 import indicatorSchema from '#components/domain/EapIndicatorInput/schema';
 import operationActivitySchema from '#components/domain/EapOperationActivityInput/schema';
 import { lengthSmallerOrEqualToCondition } from '#utils/common';
+import { positiveIntegerCondition } from '#utils/form';
 import { type GoApiBody } from '#utils/restRequest';
 
 import { charLimits } from './common';
@@ -417,7 +419,13 @@ export const formSchema: FormSchema = {
                     charLimits.potential_geographical_high_risk_areas,
                 )],
             },
-            people_targeted: { required: isSubmit },
+            people_targeted: {
+                required: isSubmit,
+                validations: [
+                    positiveIntegerCondition,
+                    lessThanOrEqualToCondition(2000),
+                ],
+            },
             assisted_through_operation: {
                 required: isSubmit,
                 requiredValidation: requiredStringCondition,