Skip to content

EAP: Bug fixes and Feedback changes in whole EAP form and section#2292

Merged
frozenhelium merged 5 commits into
project/early-action-protocolsfrom
fix/eap-feedback-changes
Apr 17, 2026
Merged

EAP: Bug fixes and Feedback changes in whole EAP form and section#2292
frozenhelium merged 5 commits into
project/early-action-protocolsfrom
fix/eap-feedback-changes

Conversation

@shreeyash07
Copy link
Copy Markdown
Collaborator

@shreeyash07 shreeyash07 commented Mar 25, 2026 •
edited
Loading

Depends On

Changes

  • update strings throughout the EAP sections and forms
  • add missing required validation in form schema
  • Update total budget in full EAP from NumberInput to TextOutput
  • access eap form according to EAP type
  • add IconButton in InfoModal
  • hide export button for staging and production
  • add lead_timeframe_unit in full eap form

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 92cb239

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 marked this pull request as ready for review April 1, 2026 05:19
@shreeyash07 shreeyash07 force-pushed the project/early-action-protocols branch 2 times, most recently from 78b8b30 to 70e93f8 Compare April 1, 2026 06:45
@shreeyash07 shreeyash07 force-pushed the fix/eap-feedback-changes branch from 35e95b2 to dc36623 Compare April 1, 2026 08:55
@shreeyash07 shreeyash07 force-pushed the project/early-action-protocols branch from 8ec4172 to 6855ade Compare April 7, 2026 09:26
@shreeyash07
fix(eap): implement feedback changes in eap sections and forms
f1ae8f3 
    - update strings throughout the EAP sections and forms
    - add missing required validation in form schema
    - Update total budget in full EAP from NumberInput to TextOutput
@shreeyash07
fix(eap-form): add eap forms access according to eap type
537c393
@shreeyash07 shreeyash07 force-pushed the fix/eap-feedback-changes branch 2 times, most recently from 727ecc3 to 9036b1d Compare April 7, 2026 10:02
frozenhelium
frozenhelium reviewed Apr 10, 2026
View reviewed changes
Comment thread app/src/components/ExplanatoryNote/index.tsx Outdated
name={undefined}
heading={heading}
modalContent={content}
icon={(<InformationLineIcon className={styles.icon} />)}
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the manual styling override here? Also, let's remove extra parenthesis.

Suggested change
icon={(<InformationLineIcon className={styles.icon} />)}
icon={<InformationLineIcon className={styles.icon} />}

frozenhelium
frozenhelium reviewed Apr 10, 2026
View reviewed changes
Comment thread app/src/views/AccountMyFormsEap/EapTableActions/i18n.json Outdated
"previewExportLinkLabel": "Preview export",
"previewSummaryExportLinkLabel": "Preview summary export",
"downloadReviewChecklistLinkLabel": "Download review checklist",
"downloadReviewChecklistLinkLabel": "Download Review checklist",
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this capitalization logic apply to other similar strings?

Copy link
Copy Markdown
Collaborator Author

@shreeyash07 shreeyash07 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been changed. you can ignore this for now

frozenhelium
frozenhelium reviewed Apr 10, 2026
View reviewed changes
Comment thread app/src/views/AccountMyFormsEap/EapTableActions/index.tsx Outdated
{type === 'development' && (
<>
{eap.eap_type === EAP_TYPE_SIMPLIFIED && isCreated && (
{environment === 'testing' && eap.eap_type === EAP_TYPE_SIMPLIFIED && isCreated && (
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium Apr 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing is usually used for the CI or while running the tests. Should we instead use it for development?

frozenhelium
frozenhelium requested changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some modals with smaller contents doesn't look good. Let's do something about it.

Image Image

@shreeyash07
Copy link
Copy Markdown
Collaborator Author

shreeyash07 commented Apr 13, 2026

Some modals with smaller contents doesn't look good. Let's do something about it.

Image Image

Some modals with smaller contents doesn't look good. Let's do something about it.

Image Image

we have to make changes, we can do this later

@shreeyash07 @frozenhelium
feat(eap): add ExplanatoryNote components in both EAP form replacing …
29ba591 
…tooltip

    - add IconButton in InfoModal
    - hide export button for staging and production
@shreeyash07 @frozenhelium
feat(go-ui): update type props in DateInput to implement month input …
b49f1d4 
…variant
@shreeyash07 @frozenhelium
fix(eap): update in whole eap module according feedback
92cb239 
    - add partners field in both eap forms
    - pass type props in every DateInput field
    - remove year option in timeFrame for readiness and prepositioning activities
    - make ap code form fields view only
    - update in translation strings
    - add missing validation for plannedOperations and enablingApproaches form fields
    - add eap apCode options for both forms
    - improve eap table action flow
    - add revise button for creating new version
    - add additional attachments modal in EAP table
    - make lead_timeframe_unit and lead_time field required
    - replace diff library to diff-match-patch
    - new DiffTextOutput components
    - update PrintableDescription and PrintableLabel components
    - add utility function for expected_submission_time field
@frozenhelium frozenhelium force-pushed the fix/eap-feedback-changes branch from 21f3983 to 92cb239 Compare April 17, 2026 02:02
@frozenhelium frozenhelium merged commit fe7a694 into project/early-action-protocols Apr 17, 2026
15 checks passed
@frozenhelium frozenhelium deleted the fix/eap-feedback-changes branch April 17, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frozenhelium frozenhelium frozenhelium approved these changes

@subinasr subinasr Awaiting requested review from subinasr

@AdityaKhatri AdityaKhatri Awaiting requested review from AdityaKhatri

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Assignees

@frozenhelium frozenhelium

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shreeyash07 @frozenhelium