From f1ae8f3d06ec3ef87fceced128c7fbf76ab39832 Mon Sep 17 00:00:00 2001 From: Shreeyash Shrestha Date: Wed, 25 Mar 2026 14:48:38 +0545 Subject: [PATCH 1/5] fix(eap): implement feedback changes in eap sections and forms - update strings throughout the EAP sections and forms - add missing required validation in form schema - Update total budget in full EAP from NumberInput to TextOutput --- .../EapTableActions/i18n.json | 4 ++-- app/src/views/AccountMyFormsLayout/i18n.json | 4 ++-- .../EapFullForm/FinanceLogistics/index.tsx | 12 +++++------ .../Overview/KeyActorsInput/index.tsx | 1 + .../SelectionActions/OperationInput/index.tsx | 3 +++ .../views/EapFullForm/TriggerModel/i18n.json | 2 +- app/src/views/EapFullForm/index.tsx | 7 +++++++ app/src/views/EapFullForm/schema.ts | 21 +++++++++++++++---- .../EapSimplifiedForm/RiskAnalysis/index.tsx | 2 +- app/src/views/EapSimplifiedForm/schema.ts | 10 ++++++++- 10 files changed, 49 insertions(+), 17 deletions(-) diff --git a/app/src/views/AccountMyFormsEap/EapTableActions/i18n.json b/app/src/views/AccountMyFormsEap/EapTableActions/i18n.json index b7706a26f5..5af45f3e42 100644 --- a/app/src/views/AccountMyFormsEap/EapTableActions/i18n.json +++ b/app/src/views/AccountMyFormsEap/EapTableActions/i18n.json @@ -5,12 +5,12 @@ "startSimplifiedEapLinkLabel": "Start sEAP", "editFullEapLinkLabel": "Edit Full EAP", "viewFullEapLinkLabel": "View Full EAP", - "exportWithChangesButtonLabel": "Export with changes", + "exportWithChangesButtonLabel": "Export with track changes", "exportButtonLabel": "Export", "exportSummaryButtonLabel": "Export Summary", "previewExportLinkLabel": "Preview export", "previewSummaryExportLinkLabel": "Preview summary export", - "downloadReviewChecklistLinkLabel": "Download review checklist", + "downloadReviewChecklistLinkLabel": "Download Review checklist", "downloadUpdatedChecklistLinkLabel": "Download updated checklist", "editSimplifiedEapLinkLabel": "Edit sEAP", "viewSimplifiedEapLinkLabel": "View sEAP", diff --git a/app/src/views/AccountMyFormsLayout/i18n.json b/app/src/views/AccountMyFormsLayout/i18n.json index c23cf7ce5b..992e8f5685 100644 --- a/app/src/views/AccountMyFormsLayout/i18n.json +++ b/app/src/views/AccountMyFormsLayout/i18n.json @@ -3,8 +3,8 @@ "strings": { "fieldReportTabTitle": "Field Report", "perTabTitle": "PER", - "drefTabTitle": "DREF", + "drefTabTitle": "DREF Applications", "threeWTabTitle": "3W", "eapApplications": "EAP Applications" } -} \ No newline at end of file +} diff --git a/app/src/views/EapFullForm/FinanceLogistics/index.tsx b/app/src/views/EapFullForm/FinanceLogistics/index.tsx index 89bc8dbc3d..9f38b54319 100644 --- a/app/src/views/EapFullForm/FinanceLogistics/index.tsx +++ b/app/src/views/EapFullForm/FinanceLogistics/index.tsx @@ -29,6 +29,7 @@ import { type PartialEapFullFormType } from '../schema'; import SectionQualityCriteria from '../SectionQualityCriteria'; import i18n from './i18n.json'; +import NonFieldError from '#components/NonFieldError'; interface Props { value: PartialEapFullFormType; @@ -162,15 +163,14 @@ function FinanceLogistics(props: Props) { )} withAsteriskOnTitle > - +