Skip to content

fix; rename extra dims #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nlenglet-ign wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix; rename extra dims #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# dev
- [fix] color: rename Deviation extra dim to PredictionOccupationSol

# 1.15.9
- [fix] color: fix main

Expand Down
11 changes: 7 additions & 4 deletions pdaltools/color.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def color_from_stream(
color_rvb_enabled=True,
color_ir_enabled=True,
veget_index_file="",
vegetation_dim="Deviation",
vegetation_dim="PredictionOccupationSol",
check_images=False,
stream_RGB="ORTHOIMAGERY.ORTHOPHOTOS",
stream_IRC="ORTHOIMAGERY.ORTHOPHOTOS.IRC",
Expand All @@ -64,7 +64,7 @@ def color_from_stream(
veget_index_file (str, optional): Path to the tiff tile to use for "vegetation_dim" colorization.
Defaults to "".
vegetation_dim (str, optional): Name of the dimension to use to store the values of "veget_index_file".
Defaults to "Deviation".
Defaults to "PredictionOccupationSol".
check_images (bool, optional): If true, check if images from the geoplateform data feed are white
(and raise and error in this case). Defaults to False.
stream_RGB (str, optional): WMS raster stream for RGB colorization:
Expand Down Expand Up @@ -164,7 +164,7 @@ def color_from_files(
color_rvb_enabled=True,
color_ir_enabled=True,
veget_index_file="",
vegetation_dim="Deviation",
vegetation_dim="PredictionOccupationSol",
):
pipeline = pdal.Reader.las(filename=input_file)

Expand Down Expand Up @@ -253,7 +253,10 @@ def add_common_options(parser):
help="Vegetation file (raster), value will be stored in 'vegetation_dim' field",
)
parser.add_argument(
"--vegetation_dim", type=str, default="Deviation", help="name of the extra_dim uses for the vegetation value"
"--vegetation_dim",
type=str,
default="PredictionOccupationSol",
help="name of the extra_dim uses for the vegetation value",
)


Expand Down
Binary file modified test/data/las_with_several_extra_byte_bloc.laz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion test/test_pdal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_pdal_read_severals_extra_dims():
metadata = pipeline.quickinfo["readers.las"]

# dimensions should contains 'Deviation' and 'confidence'
assert "Deviation" in metadata["dimensions"]
assert "PredictionOccupationSol" in metadata["dimensions"]
assert "confidence" in metadata["dimensions"]

# Test Python PDAL bindings
Expand Down
Loading