fix: rename internal drag-drop MIME type to RFC 6838 form (#1468)

* fix: rename internal drag-drop MIME type to RFC 6838 form

The internal MIME identifier QtPass uses for drag-and-drop payloads
was registered as "application/vnd+qtpass.dragAndDropInfoPasswordStore".
The '+' in that form is reserved for structured-syntax suffixes (e.g.
"application/atom+xml") in RFC 6838; the vendor-tree separator is
'.'. Rename to "application/vnd.qtpass.dragAndDropInfoPasswordStore".

Used in exactly 9 places, all inside QtPass:
- src/storemodel.cpp: mimeTypes(), mimeData(), canDropMimeData() x2,
  parseDropData()
- tests/auto/model/tst_storemodel.cpp: 4 assertions + makeMimeData()

Internal-only identifier (drag/drop happens between QtPass widgets in
the same process), so no compatibility break.

Also rearrange the test include block — <memory> now sits with the
C++ stdlib headers above the Qt headers, matching the
stdlib-then-Qt-then-project convention used elsewhere.

Build clean, 33/33 storemodel tests pass.

Other CodeRabbit nits in tst_util.cpp (DF9 underscore, hoist
ASSUMED_MAX_KEY_ID_LENGTH, ScopedUmask RAII) were re-evaluated and
still skipped — same rationale as #1467.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test: QVERIFY2 on the two MIME-type assertions

CodeRabbit nit on #1468 follow-up: bare QVERIFY() on the
mimeTypes()/mimeData() assertions doesn't say which MIME string was
expected if the test fails. Switch to QVERIFY2 with descriptive
messages.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: annejan

src/storemodel.cpp

@@ -193,7 +193,7 @@ auto StoreModel::flags(const QModelIndex &index) const -> Qt::ItemFlags {
  */
 auto StoreModel::mimeTypes() const -> QStringList {
   QStringList types;
-  types << "application/vnd+qtpass.dragAndDropInfoPasswordStore";
+  types << "application/vnd.qtpass.dragAndDropInfoPasswordStore";
   return types;
 }
 
@@ -223,7 +223,7 @@ auto StoreModel::mimeData(const QModelIndexList &indexes) const -> QMimeData * {
   }
 
   auto *mimeData = new QMimeData();
-  mimeData->setData("application/vnd+qtpass.dragAndDropInfoPasswordStore",
+  mimeData->setData("application/vnd.qtpass.dragAndDropInfoPasswordStore",
                     encodedData);
   return mimeData;
 }
@@ -248,12 +248,12 @@ auto StoreModel::canDropMimeData(const QMimeData *data, Qt::DropAction action,
 #endif
 
   if (data == nullptr ||
-      !data->hasFormat("application/vnd+qtpass.dragAndDropInfoPasswordStore")) {
+      !data->hasFormat("application/vnd.qtpass.dragAndDropInfoPasswordStore")) {
     return false;
   }
 
   QByteArray encodedData =
-      data->data("application/vnd+qtpass.dragAndDropInfoPasswordStore");
+      data->data("application/vnd.qtpass.dragAndDropInfoPasswordStore");
   if (encodedData.isEmpty()) {
     return false;
   }
@@ -324,7 +324,7 @@ auto StoreModel::dropMimeData(const QMimeData *data, Qt::DropAction action,
 auto StoreModel::parseDropData(const QMimeData *data,
                                dragAndDropInfoPasswordStore *outInfo) -> bool {
   QByteArray encodedData =
-      data->data("application/vnd+qtpass.dragAndDropInfoPasswordStore");
+      data->data("application/vnd.qtpass.dragAndDropInfoPasswordStore");
   if (encodedData.isEmpty()) {
     return false;
   }

tests/auto/model/tst_storemodel.cpp

@@ -1,13 +1,13 @@
 // SPDX-FileCopyrightText: 2026 Anne Jan Brouwer
 // SPDX-License-Identifier: GPL-3.0-or-later
+#include <memory>
+
 #include <QDataStream>
 #include <QDir>
 #include <QFileSystemModel>
 #include <QMimeData>
 #include <QtTest>
 
-#include <memory>
-
 #include "../../../src/storemodel.h"
 
 class tst_storemodel : public QObject {
@@ -101,8 +101,10 @@ void tst_storemodel::flagsWithInvalidIndex() {
 void tst_storemodel::mimeTypes() {
   StoreModel sm;
   QStringList types = sm.mimeTypes();
-  QVERIFY(
-      types.contains("application/vnd+qtpass.dragAndDropInfoPasswordStore"));
+  QVERIFY2(
+      types.contains("application/vnd.qtpass.dragAndDropInfoPasswordStore"),
+      "mimeTypes() should advertise "
+      "application/vnd.qtpass.dragAndDropInfoPasswordStore");
 }
 
 void tst_storemodel::lessThan() {
@@ -218,9 +220,11 @@ void tst_storemodel::mimeData() {
   QModelIndex sourceIndex = fsm.index(tempDir.path() + "/testfile.gpg");
   QModelIndex proxyIndex = sm.mapFromSource(sourceIndex);
   QMimeData *data = sm.mimeData(QModelIndexList() << proxyIndex);
-  QVERIFY(data != nullptr);
-  QVERIFY(
-      data->hasFormat("application/vnd+qtpass.dragAndDropInfoPasswordStore"));
+  QVERIFY2(data != nullptr, "mimeData() should return a non-null QMimeData");
+  QVERIFY2(
+      data->hasFormat("application/vnd.qtpass.dragAndDropInfoPasswordStore"),
+      "mimeData() should carry "
+      "application/vnd.qtpass.dragAndDropInfoPasswordStore");
   delete data;
 }
 
@@ -298,7 +302,7 @@ auto makeMimeData(dragAndDropInfoPasswordStore::ItemKind kind,
   stream << info;
 
   auto mime = std::make_unique<QMimeData>();
-  mime->setData("application/vnd+qtpass.dragAndDropInfoPasswordStore", encoded);
+  mime->setData("application/vnd.qtpass.dragAndDropInfoPasswordStore", encoded);
   return mime;
 }
 
@@ -404,7 +408,7 @@ void tst_storemodel::canDropWrongMimeType() {
 void tst_storemodel::canDropEmptyEncodedData() {
   DropFixture fx;
   QMimeData mime;
-  mime.setData("application/vnd+qtpass.dragAndDropInfoPasswordStore",
+  mime.setData("application/vnd.qtpass.dragAndDropInfoPasswordStore",
                QByteArray());
   QVERIFY(
       !fx.sm.canDropMimeData(&mime, Qt::MoveAction, 0, 0, fx.folderProxy()));