chore: clang-format two over-long QVERIFY2 lines in tst_integration.cpp#1475
Conversation
CodeRabbit's auto-fix on #1471 captured the QFile::write() return value and asserted it equals the payload size — sensible nit. The resulting QVERIFY2 calls busted the 80-col limit and the super-linter is rejecting unrelated PRs (#1474 head was 7430a35) because clang-format runs over the whole tree. Reformat both calls — break after the condition, matches the style of all the other QVERIFY2 sites added in earlier security PRs. No semantic change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single-line ChangesTest assertion formatting
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
- Coverage 34.43% 34.38% -0.05%
==========================================
Files 44 44
Lines 4385 4385
==========================================
- Hits 1510 1508 -2
- Misses 2875 2877 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary
CI super-linter started rejecting unrelated PRs because clang-format runs over the whole tree and two lines in `tst_integration.cpp` exceed the 80-col limit:
```
/github/workspace/tests/auto/integration/tst_integration.cpp:430:67: error: code should be clang-formatted [-Wclang-format-violations]
QVERIFY2(bytesWritten1 == static_cast(strlen(payload1)), "failed to write test payload to c1");
^
/github/workspace/tests/auto/integration/tst_integration.cpp:436:48: error: code should be clang-formatted [-Wclang-format-violations]
QVERIFY2(bytesWritten2 == corruptData.size(), "failed to write test payload to c2");
^
```
Those came from CodeRabbit's auto-fix on #1471 that captured the `QFile::write()` return value and asserted it equals the payload size. The change was good, the formatting just slipped past.
Reformat both calls — break after the condition, matches the QVERIFY2 style applied elsewhere.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Note: This release contains no user-visible changes. Updates are limited to internal test code formatting.