Skip to content

Commit 4b80677

Browse files
committed
improved menu and popups ui
1 parent dc6fa4e commit 4b80677

4 files changed

Lines changed: 32 additions & 39 deletions

File tree

webmoti-react/src/components/Buttons/ToggleScheduleButton/ToggleScheduleButton.tsx

Lines changed: 0 additions & 27 deletions
This file was deleted.

webmoti-react/src/components/MenuBar/Menu/Menu.tsx

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,10 @@ export default function Menu({ buttonClassName }: MenuProps) {
128128
{
129129
icon: <SettingsIcon />,
130130
label: 'Audio and Video Settings',
131-
onClick: () => setSettingsOpen(true),
131+
onClick: () => {
132+
setSettingsOpen(true);
133+
setMenuOpen(false);
134+
},
132135
},
133136
...(isSupported
134137
? [
@@ -164,19 +167,28 @@ export default function Menu({ buttonClassName }: MenuProps) {
164167
{
165168
icon: <CalendarTodayIcon style={{ fill: '#707578', width: '0.9em' }} />,
166169
label: 'Set Schedule',
167-
onClick: () => setSetScheduleOpen(true),
170+
onClick: () => {
171+
setSetScheduleOpen(true);
172+
setMenuOpen(false);
173+
},
168174
},
169175
{
170176
icon: <CalendarViewDayIcon style={{ fill: '#707578', width: '0.9em' }} />,
171177
label: 'View Schedule',
172-
onClick: () => setViewScheduleOpen(true),
178+
onClick: () => {
179+
setViewScheduleOpen(true);
180+
setMenuOpen(false);
181+
},
173182
},
174183
...(!isSharingScreen && !isMobile
175184
? [
176185
{
177186
icon: <ScreenShareIcon />,
178187
label: SCREEN_SHARE_TEXT,
179-
onClick: toggleScreenShare,
188+
onClick: () => {
189+
toggleScreenShare();
190+
setMenuOpen(false);
191+
},
180192
disabled: isScreenShareDisabled,
181193
tooltip: getTooltipMessage(),
182194
},
@@ -197,12 +209,18 @@ export default function Menu({ buttonClassName }: MenuProps) {
197209
{
198210
icon: <InfoIconOutlined />,
199211
label: 'About',
200-
onClick: () => setAboutOpen(true),
212+
onClick: () => {
213+
setAboutOpen(true);
214+
setMenuOpen(false);
215+
},
201216
},
202217
{
203218
icon: <SupervisorAccountIcon style={{ fill: '#707578', width: '0.9em' }} />,
204219
label: 'Admin',
205-
onClick: handleAdminLogin,
220+
onClick: () => {
221+
handleAdminLogin();
222+
setMenuOpen(false);
223+
},
206224
},
207225
{
208226
isCustomComponent: true,

webmoti-react/src/components/SetScheduleModal/SetScheduleModal.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const StyledModal = styled(Modal)(({ theme }) => ({
2626
border: '2px solid #000',
2727
boxShadow: theme.shadows[5],
2828
padding: theme.spacing(2, 4, 3),
29+
zIndex: theme.zIndex.modal + 1,
2930
},
3031
}));
3132

@@ -118,8 +119,8 @@ export default function SetScheduleModal({ open, onClose }: SetScheduleModalProp
118119
onClose={onClose}
119120
className={classes.modal}
120121
closeAfterTransition
121-
BackdropComponent={Backdrop}
122-
BackdropProps={{ timeout: 500 }}
122+
slots={{ backdrop: Backdrop }}
123+
slotProps={{ backdrop: { timeout: 500 } }}
123124
>
124125
<Fade in={open}>
125126
<div className={classes.paper}>
@@ -136,7 +137,7 @@ export default function SetScheduleModal({ open, onClose }: SetScheduleModalProp
136137
fullWidth
137138
style={{ marginBottom: '20px' }}
138139
slotProps={{
139-
inputLabel: { shrink: true }
140+
inputLabel: { shrink: true },
140141
}}
141142
/>
142143

@@ -149,7 +150,7 @@ export default function SetScheduleModal({ open, onClose }: SetScheduleModalProp
149150
fullWidth
150151
style={{ marginBottom: '20px' }}
151152
slotProps={{
152-
inputLabel: { shrink: true }
153+
inputLabel: { shrink: true },
153154
}}
154155
/>
155156

webmoti-react/src/components/ViewScheduleModal/ViewScheduleModal.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ const StyledModal = styled(Modal)(({ theme }) => ({
4141
border: '2px solid #000',
4242
boxShadow: theme.shadows[5],
4343
padding: theme.spacing(2, 4, 3),
44+
zIndex: theme.zIndex.modal + 1,
4445
},
4546
}));
4647

@@ -83,8 +84,8 @@ export default function ViewScheduleModal({ open, onClose }: ViewScheduleModalPr
8384
onClose={onClose}
8485
className={classes.modal}
8586
closeAfterTransition
86-
BackdropComponent={Backdrop}
87-
BackdropProps={{ timeout: 500 }}
87+
slots={{ backdrop: Backdrop }}
88+
slotProps={{ backdrop: { timeout: 500 } }}
8889
>
8990
<Fade in={open}>
9091
<div className={classes.paper}>

0 commit comments

Comments
 (0)