Moved copy dms files after duplication to execute after next edit

Author: chris-adam

imio/dms/mail/subscribers.py

@@ -567,6 +567,16 @@ def dmsoutgoingmail_added(mail, event):
         zope.event.notify(ObjectModifiedEvent(mail, Attributes(ISigningBehavior, "ISigningBehavior.signers")))
 
 
+def dmsoutgoingmail_modified(mail, event):
+    annot = IAnnotations(mail).get('imio.dms.mail', {})
+    copy_dms_files_from = annot.get('copy_dms_files_from')
+    if copy_dms_files_from:
+        del annot['copy_dms_files_from']
+        original_mail = uuidToObject(copy_dms_files_from, unrestricted=True)
+        odm_utils = getMultiAdapter((mail, mail.REQUEST), name="odm-utils")
+        odm_utils.copy_dms_files(original_mail)
+
+
 def dv_handle_file_creation(obj, event):
     """Intermediate function to avoid converting some files in documentviewer"""
     if obj.portal_type in DV_AVOIDED_TYPES:

imio/dms/mail/tests/test_utils.py

@@ -939,7 +939,7 @@ def test_OdmUtilsMethods_duplicate(self):
             keep_annexes=True,
             link_to_duplicated=True,
         )
-        self.assertEqual(duplicated_mail.keys(), ['012999900000004', 'a001'])
+        self.assertEqual(duplicated_mail.keys(), ['a001', '012999900000004'])
         dms_file = duplicated_mail['012999900000004']
         annot = IAnnotations(dms_file)['documentgenerator']
         self.assertEqual(annot['template_uid'], pod_template.UID())

imio/dms/mail/utils.py

@@ -1248,36 +1248,10 @@ def duplicate(self, keep_category, keep_folder, keep_reply_to, keep_dms_files, k
             duplicated_mail.reply_to = original_mail.reply_to[:]
 
         if keep_dms_files:
-            dms_files = [sub_content for sub_content in original_mail.values() if sub_content.portal_type == self.mainfile_type]
-            used_template_uids = set()
-            for dms_file in dms_files:
-                annot = IAnnotations(dms_file).get('documentgenerator', {})
-
-                # Skip if document was not generated (could be scanned)
-                if not annot:
-                    continue
-
-                # Skip if document was already generated from the same template
-                if annot.get('template_uid') in used_template_uids:
-                    continue
-
-                # Skip if document is final step of a mailing
-                document_generation_helper_view = getMultiAdapter((duplicated_mail, self.request), name="document_generation_helper_view")
-                requires_mailing = len(document_generation_helper_view.mailing_list()) > 1
-                if requires_mailing and not annot.get('need_mailing'):
-                    continue
-
-                # Generate a new document from the same template
-                template_uid = annot.get('template_uid')
-                generation_view = getMultiAdapter((duplicated_mail, self.request), name="persistent-document-generation")
-                pod_template = generation_view.get_pod_template(template_uid)
-                # Skip if it's a mailing loop template
-                if IMailingLoopTemplate.providedBy(pod_template):
-                    continue
-                generation_view.pod_template = pod_template
-                generation_view.output_format = 'odt'
-                generation_view.generate_persistent_doc(pod_template, 'odt')
-                used_template_uids.add(template_uid)
+            # Add an annotation to copy DMS files only after next edit
+            annot = IAnnotations(duplicated_mail)
+            annot.setdefault('imio.dms.mail', PersistentDict())  # make sure the key exists
+            annot['imio.dms.mail']['copy_dms_files_from'] = original_mail.UID()
 
         if keep_annexes:
             annexes = [sub_content.getId() for sub_content in original_mail.values() if IDmsAppendixFile.providedBy(sub_content)]
@@ -1294,6 +1268,39 @@ def duplicate(self, keep_category, keep_folder, keep_reply_to, keep_dms_files, k
 
         return duplicated_mail
 
+    def copy_dms_files(self, original_mail):
+        """Re-generate DMS files on this mail based on the templates used in the original mail."""
+        dms_files = [sub_content for sub_content in original_mail.values() if sub_content.portal_type == self.mainfile_type]
+        used_template_uids = set()
+        for dms_file in dms_files:
+            annot = IAnnotations(dms_file).get('documentgenerator', {})
+
+            # Skip if document was not generated (could be scanned)
+            if not annot:
+                continue
+
+            # Skip if document was already generated from the same template
+            if annot.get('template_uid') in used_template_uids:
+                continue
+
+            # Skip if document is final step of a mailing
+            document_generation_helper_view = getMultiAdapter((self.context, self.request), name="document_generation_helper_view")
+            requires_mailing = len(document_generation_helper_view.mailing_list()) > 1
+            if requires_mailing and not annot.get('need_mailing'):
+                continue
+
+            # Generate a new document from the same template
+            template_uid = annot.get('template_uid')
+            generation_view = getMultiAdapter((self.context, self.request), name="persistent-document-generation")
+            pod_template = generation_view.get_pod_template(template_uid)
+            # Skip if it's a mailing loop template
+            if IMailingLoopTemplate.providedBy(pod_template):
+                continue
+            generation_view.pod_template = pod_template
+            generation_view.output_format = 'odt'
+            generation_view.generate_persistent_doc(pod_template, 'odt')
+            used_template_uids.add(template_uid)
+
 
 class Dummy(object):
     """dummy class that allows setting attributes"""