PARAF-166: Updated robotframework tests to include electronic signature

[chris-adam]

Summary

Adds two new Robot Framework documentation scenarios to doc.robot covering the
outgoing-mail signature flows: Signature écrite (manual/written signature →
to_be_signed) and Signature électronique (approval chain + e-signing →
to_approve, sequential approval by Directeur Général then Bourgmestre, then the
auto-created eSign session and the Paraphéo tab). E-signing is activated once for the
whole suite in Suite Setup via the existing imiodmsmail-activate-esigning singles
step. Both scenarios carry French educational annotations and "connected user"
banners at every user switch so they can be recorded as video documentation. Two
reusable keywords (Show connected user, Add outgoing mail for signing) were added
to the suite, and a SELENIUM_SPEED variable allows slowing a run for screen capture.

Ticket

PARAF-166 — https://support-imio.atlassian.net/browse/PARAF-166

Pre-PR checks

• CHANGES up to date
• Tests exist for new code
• Diff matches ticket
• No debug leftovers
• No stray files / secrets
• Profile / version bumps (if applicable)
• Commits reference ticket / mergeable

Commits

db923e8 PARAF-166: Updated robotframework tests to include electronic signature

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Expanded end-to-end Robot Framework coverage for both “Signature écrite” and “Signature électronique”, including document generation and workflow steps across multiple users.
  • Added configurable Selenium pacing and improved UI interaction stability (window resize/restore around key screenshots).
  • Improved signing-related UI targeting and corrected send mode selection behavior for sign-mail flows.
  • Added reusable Robot keywords to activate e-signing setup, show connected-user context, and create outgoing signing mails.
• Documentation
  • Updated the unreleased changelog entry to clarify that Robot tests now include electronic signature coverage.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

📝 Walkthrough

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: updating Robot Framework tests to include electronic signature testing, which aligns with the primary objective of adding new signature workflow test scenarios.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch PARAF-166/robot

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

imio/dms/mail/tests/robot/doc.robot (1)

1488-1489: 💤 Low value

Consider explicit wait after approval actions.

The approval clicks are followed only by Sleep 1 without verifying the action completed. While subsequent steps provide implicit validation, an explicit wait (e.g., for a success indicator or state change) would make these steps more robust against timing variations in CI.

This follows existing patterns in the file, so it may be acceptable for documentation-focused tests.

Also applies to: 1496-1497

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@imio/dms/mail/tests/robot/doc.robot` around lines 1488 - 1489, Replace the
`Sleep 1` statements that follow the approval action clicks (after `Click
element css=`#fieldset-versions` td.iconified-approved
a.iconified-action.editable` and similar approval clicks in the file) with
explicit waits that verify the action completed, such as waiting for a success
indicator to appear or for a specific element state to change. This applies to
the approval click statements at lines 1488-1489 and 1496-1497, making the tests
more robust against timing variations rather than relying on fixed sleep
durations.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@imio/dms/mail/tests/robot/doc.robot`:
- Around line 1488-1489: Replace the `Sleep 1` statements that follow the
approval action clicks (after `Click element css=`#fieldset-versions`
td.iconified-approved a.iconified-action.editable` and similar approval clicks
in the file) with explicit waits that verify the action completed, such as
waiting for a success indicator to appear or for a specific element state to
change. This applies to the approval click statements at lines 1488-1489 and
1496-1497, making the tests more robust against timing variations rather than
relying on fixed sleep durations.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 35f1bf2e-5c95-411e-81b3-7bcf5dd82ccc

📥 Commits

Reviewing files that changed from the base of the PR and between 4a39dc6 and db923e8.

📒 Files selected for processing (2)

• CHANGES.rst
• imio/dms/mail/tests/robot/doc.robot

[chris-adam]

@sgeulette @bleybaert J'ai fini de mettre à jour robot framework pour l aversion 3.1.x. Par contre, je ne suis pas trop convaincu des nouveaux screenshots pour la signature électronique. On pourra voir ça ensemble

[chris-adam]

@sgeulette Je propose qu'on valide déjà l'implémentation et qu'on s'attarde sur les screenshots dans une autre PR quand on voudra mettre à jour la doc

Le bug des datadrigfields dans les settings a été fixé