Externalize OLS implementation#270
Merged
Merged
Conversation
This PR switches out interaction with the EBI's ontology lookup service using the `ols-client` package, which enables interaction with alternative OLS instances like the TIB Hannover one. Probably of interest to @StroemPhi
|
Oooh cool! Thank you @cthoyt, am definitely interested! |
Collaborator
|
Thanks @cthoyt this is awesome! I have no idea why that 3.10 test is failing @StroemPhi if you can install a python module you can be doing awesome things on the command line in seconds, ping me on slack with what kind of thing you’d find most useful |
Collaborator
|
I think rebase should fix (gets rid of the problematic switch on the nx code) but odd how it got into this state in the first place |
cmungall
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches out interaction with the EBI's ontology lookup service using the
ols-clientpackage, similarly to how we externalized some functionality for OntoPortal instances in #204.Further, this enables interaction with alternative OLS instances like the TIB Hannover one. Probably of interest to @StroemPhi.