Test upgrade of linkml-runtime to 1.9.1-rc1#839
Open
sierra-moxon wants to merge 10 commits intomainfrom
Open
Conversation
…educe verbosity of test output
dalito
reviewed
Apr 9, 2025
| result = self.runner.invoke(main, ["--help"]) | ||
| out = result.stdout | ||
| print("STDERR", result.stderr) | ||
| logging.info("STDERR", result.stderr) |
Contributor
There was a problem hiding this comment.
Maybe switch to a named logger as suggested here (tutorial or logging cookbook).
To change insert after the import section
logger = logging.getLogger(__name__)
and then replace all logging.debug, ligging.info etc. by logger.debug, logger.info etc.
linkml-runtime also does it this way (test_schemaview.py).
Contributor
Author
There was a problem hiding this comment.
yep! definitely. not done with this implementation at all, just first pass at getting the output a bit more grok'able so I can see the breaking errors.
Contributor
Author
There was a problem hiding this comment.
I think this refactoring should go in another PR. The changes here are consistent with the rest of the library and I captured the next step we need to take here: #838
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also reduces some test verbosity (move print -> logging.info, but the logger is not configured to completion)
adds a short-cut
make lint-fixtarget.