Skip to content

Commit b8aabec

Browse files
committed
Avoid copying release files prematurely.
Do not make `prepare_release` depend on `copy_release_files`. If attemtping a parallel build (make -j X), this could lead Make to execute the `copy_release_files` even before the `all_odk` target has been completed (and thus, before all release files have been built). So instead, we depend on `all_odk` only and we explicitly call the `copy_release_files` target.
1 parent afbf151 commit b8aabec

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

template/src/ontology/Makefile.jinja2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,8 @@ CLEANFILES=$(MAIN_FILES) $(SRCMERGED) $(EDIT_PREPROCESSED)
435435
# This should be executed by the release manager whenever time comes to make a release.
436436
# It will ensure that all assets/files are fresh, and will copy to release folder
437437
.PHONY: prepare_release
438-
prepare_release: all_odk copy_release_files
438+
prepare_release: all_odk
439+
$(MAKE) copy_release_files
439440
rm -f $(CLEANFILES)
440441
@echo "Release files are now in $(RELEASEDIR) - now you should commit, push and make a release \
441442
on your git hosting site such as GitHub or GitLab"

0 commit comments

Comments
 (0)