Clarify comments inside python-requirements.txt.#1344
Merged
Conversation
The comments within the `python-requirements.txt` file were misleading,
as they were suggesting that the file listed both packages needed for
ODK-Lite ("core dependencies") and for ODK-Full ("secondary
dependencies").
This commit clarifies the contents of the python-requirements.txt by
breaking it down in three sections:
(A) The section with the dependencies needed for ODK-Lite -- which, by
definition, only contain the ODK-Core package.
(B) The section containing all the Python packages that should be, as
much as possible, always kept to their most recent versions ("first-tier
dependencies").
(C) The section containing all the other packages wanted for ODK-Full.
This commit also adds to the (C) section the `linkml-map` package. For
now, that package is already included in ODK-Full because it is an
indirect dependency of something else, but that may change (as we
observed when trying to update the base image to Ubunty 26.04, where
`linkml-map` is no longer included), so we make `linkml-map` an
_explicit_ dependency.
closes #1340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments within the
python-requirements.txtfile were misleading, as they were suggesting that the file listed both packages needed for ODK-Lite ("core dependencies") and for ODK-Full ("secondary dependencies").This PR clarifies the contents of the python-requirements.txt by breaking it down in three sections:
(A) The section with the dependencies needed for ODK-Lite -- which, by definition, only contain the ODK-Core package.
(B) The section containing all the Python packages that should be, as much as possible, always kept to their most recent versions ("first-tier dependencies").
(C) The section containing all the other packages wanted for ODK-Full.
This commit also adds to the (C) section the
linkml-mappackage. For now, that package is already included in ODK-Full because it is an indirect dependency of something else, but that may change (as we observed when trying to update the base image to Ubunty 26.04, wherelinkml-mapis no longer included), so we makelinkml-mapan explicit dependency.closes #1340