Skip to content

Commit ecec0a8

Browse files
committed
[ci skip] MTN Exercise M4.01 target correction (#871) 1ee99d0
1 parent 608099d commit ecec0a8

6 files changed

Lines changed: 14 additions & 14 deletions

File tree

_sources/python_scripts/linear_models_ex_01.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
penguins = pd.read_csv("../datasets/penguins_regression.csv")
4141
feature_name = "Flipper Length (mm)"
4242
target_name = "Body Mass (g)"
43-
data, target = penguins[[feature_name]], penguins[target_name]
43+
data, target = penguins[[feature_name]], penguins[[target_name]]
4444

4545
# %% [markdown]
4646
# ### Model definition

_sources/python_scripts/linear_models_sol_01.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
penguins = pd.read_csv("../datasets/penguins_regression.csv")
3535
feature_name = "Flipper Length (mm)"
3636
target_name = "Body Mass (g)"
37-
data, target = penguins[[feature_name]], penguins[target_name]
37+
data, target = penguins[[feature_name]], penguins[[target_name]]
3838

3939
# %% [markdown]
4040
# ### Model definition
@@ -106,7 +106,7 @@ def linear_model_flipper_mass(
106106
def goodness_fit_measure(true_values, predictions):
107107
# we compute the error between the true values and the predictions of our
108108
# model
109-
errors = np.ravel(true_values) - np.ravel(predictions)
109+
errors = true_values - predictions
110110
# We have several possible strategies to reduce all errors to a single value.
111111
# Computing the mean error (sum divided by the number of element) might seem
112112
# like a good solution. However, we have negative errors that will misleadingly

appendix/notebook_timings.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1007,9 +1007,9 @@ <h1>Notebook timings<a class="headerlink" href="#notebook-timings" title="Link t
10071007
<td><p></p></td>
10081008
</tr>
10091009
<tr class="row-odd"><td><p><a class="xref doc reference internal" href="../python_scripts/linear_models_ex_01.html"><span class="doc">python_scripts/linear_models_ex_01</span></a></p></td>
1010-
<td><p>2026-01-15 15:37</p></td>
1010+
<td><p>2026-01-19 09:44</p></td>
10111011
<td><p>cache</p></td>
1012-
<td><p>1.31</p></td>
1012+
<td><p>1.45</p></td>
10131013
<td><p></p></td>
10141014
</tr>
10151015
<tr class="row-even"><td><p><a class="xref doc reference internal" href="../python_scripts/linear_models_ex_02.html"><span class="doc">python_scripts/linear_models_ex_02</span></a></p></td>
@@ -1043,9 +1043,9 @@ <h1>Notebook timings<a class="headerlink" href="#notebook-timings" title="Link t
10431043
<td><p></p></td>
10441044
</tr>
10451045
<tr class="row-odd"><td><p><a class="xref doc reference internal" href="../python_scripts/linear_models_sol_01.html"><span class="doc">python_scripts/linear_models_sol_01</span></a></p></td>
1046-
<td><p>2026-01-15 15:37</p></td>
1046+
<td><p>2026-01-19 09:44</p></td>
10471047
<td><p>cache</p></td>
1048-
<td><p>2.29</p></td>
1048+
<td><p>2.86</p></td>
10491049
<td><p></p></td>
10501050
</tr>
10511051
<tr class="row-even"><td><p><a class="xref doc reference internal" href="../python_scripts/linear_models_sol_02.html"><span class="doc">python_scripts/linear_models_sol_02</span></a></p></td>

python_scripts/linear_models_ex_01.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ <h3>Data loading<a class="headerlink" href="#data-loading" title="Link to this h
738738
<span class="n">penguins</span> <span class="o">=</span> <span class="n">pd</span><span class="o">.</span><span class="n">read_csv</span><span class="p">(</span><span class="s2">&quot;../datasets/penguins_regression.csv&quot;</span><span class="p">)</span>
739739
<span class="n">feature_name</span> <span class="o">=</span> <span class="s2">&quot;Flipper Length (mm)&quot;</span>
740740
<span class="n">target_name</span> <span class="o">=</span> <span class="s2">&quot;Body Mass (g)&quot;</span>
741-
<span class="n">data</span><span class="p">,</span> <span class="n">target</span> <span class="o">=</span> <span class="n">penguins</span><span class="p">[[</span><span class="n">feature_name</span><span class="p">]],</span> <span class="n">penguins</span><span class="p">[</span><span class="n">target_name</span><span class="p">]</span>
741+
<span class="n">data</span><span class="p">,</span> <span class="n">target</span> <span class="o">=</span> <span class="n">penguins</span><span class="p">[[</span><span class="n">feature_name</span><span class="p">]],</span> <span class="n">penguins</span><span class="p">[[</span><span class="n">target_name</span><span class="p">]]</span>
742742
</pre></div>
743743
</div>
744744
</div>

python_scripts/linear_models_sol_01.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ <h3>Data loading<a class="headerlink" href="#data-loading" title="Link to this h
738738
<span class="n">penguins</span> <span class="o">=</span> <span class="n">pd</span><span class="o">.</span><span class="n">read_csv</span><span class="p">(</span><span class="s2">&quot;../datasets/penguins_regression.csv&quot;</span><span class="p">)</span>
739739
<span class="n">feature_name</span> <span class="o">=</span> <span class="s2">&quot;Flipper Length (mm)&quot;</span>
740740
<span class="n">target_name</span> <span class="o">=</span> <span class="s2">&quot;Body Mass (g)&quot;</span>
741-
<span class="n">data</span><span class="p">,</span> <span class="n">target</span> <span class="o">=</span> <span class="n">penguins</span><span class="p">[[</span><span class="n">feature_name</span><span class="p">]],</span> <span class="n">penguins</span><span class="p">[</span><span class="n">target_name</span><span class="p">]</span>
741+
<span class="n">data</span><span class="p">,</span> <span class="n">target</span> <span class="o">=</span> <span class="n">penguins</span><span class="p">[[</span><span class="n">feature_name</span><span class="p">]],</span> <span class="n">penguins</span><span class="p">[[</span><span class="n">target_name</span><span class="p">]]</span>
742742
</pre></div>
743743
</div>
744744
</div>
@@ -823,7 +823,7 @@ <h2>Main exercise<a class="headerlink" href="#main-exercise" title="Link to this
823823
<span class="k">def</span><span class="w"> </span><span class="nf">goodness_fit_measure</span><span class="p">(</span><span class="n">true_values</span><span class="p">,</span> <span class="n">predictions</span><span class="p">):</span>
824824
<span class="c1"># we compute the error between the true values and the predictions of our</span>
825825
<span class="c1"># model</span>
826-
<span class="n">errors</span> <span class="o">=</span> <span class="n">np</span><span class="o">.</span><span class="n">ravel</span><span class="p">(</span><span class="n">true_values</span><span class="p">)</span> <span class="o">-</span> <span class="n">np</span><span class="o">.</span><span class="n">ravel</span><span class="p">(</span><span class="n">predictions</span><span class="p">)</span>
826+
<span class="n">errors</span> <span class="o">=</span> <span class="n">true_values</span> <span class="o">-</span> <span class="n">predictions</span>
827827
<span class="c1"># We have several possible strategies to reduce all errors to a single value.</span>
828828
<span class="c1"># Computing the mean error (sum divided by the number of element) might seem</span>
829829
<span class="c1"># like a good solution. However, we have negative errors that will misleadingly</span>
@@ -859,15 +859,15 @@ <h2>Main exercise<a class="headerlink" href="#main-exercise" title="Link to this
859859
<div class="cell_output docutils container">
860860
<div class="output stream highlight-myst-ansi notranslate"><div class="highlight"><pre><span></span>Model #0:
861861
-40.00 (g / mm) * flipper length + 15000.00 (g)
862-
Error: 2764.854
862+
Error: nan
863863

864864
Model #1:
865865
45.00 (g / mm) * flipper length + -5000.00 (g)
866-
Error: 338.523
866+
Error: nan
867867

868868
Model #2:
869869
90.00 (g / mm) * flipper length + -14000.00 (g)
870-
Error: 573.041
870+
Error: nan
871871
</pre></div>
872872
</div>
873873
</div>

searchindex.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)