Update to sklearn 1.8#872
Conversation
|
Thanks for the PR @SebastienMelo! In principle the jupyter-book build in the CI was fixed in #873. You just have to merge main for it to work. |
* MNT Bump jupyter-book version * Pin jupyter-book<2.0 instead * Iter --------- Co-authored-by: ArturoAmorQ <arturo.amor-quiroz@polytechnique.edu>
|
All checks have been done. The wrap up quizzes work too. |
ArturoAmorQ
left a comment
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Other than the improvements in the html representation of estimators, v1.9 did not bring any impact to the course material. We can use this PR to directly target such version.
Otherwise this PR is good to go :) Thanks @SebastienMelo!
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
This reverts commit 9abf212.
|
I decided to keep the scope of this PR to v1.8, as v1.9 introduced behavior changes in DecisionBoundaryDisplay, so it's worth it's own PR and is left as future work. |
ArturoAmorQ
left a comment
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Let's rather fix to strictly 1.8 to avoid the problem with DesicionBoundaryDisplay
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
2 participants
Do not merge, I still need to check if the jupyter preview works correctly