[Added][Globals] disable_kicad_cross_on_fab to disable KiCad crosses

- KiCad 9 changes its default behavior and crosses DNPs on Fab layer,
  making impossible to have no crosses.
- So now we disable it.

Fixes #866

Author: set-soft

CHANGELOG.md

@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Global options:
   - `update_pcb_text_cache`: Used to copy the text variables from the project
     to the PCB file (#860 #861)
+  - `disable_kicad_cross_on_fab`: To avoid KiCad 9 crosses on Fab layer, so
+    only KiBot controls it (#866)
 - Internal templates:
   - PCB2Blender_2_17: generates a pcb2blender 2.17 file to import on Blender
 - Pre-flights:

docs/source/Changelog.rst

@@ -28,6 +28,8 @@ Added
 
    -  ``update_pcb_text_cache``: Used to copy the text variables from
       the project to the PCB file (#860 #861)
+   -  ``disable_kicad_cross_on_fab``: To avoid KiCad 9 crosses on Fab
+      layer, so only KiBot controls it (#866)
 
 -  Internal templates:
 

docs/source/configuration/sup_globals.rst

@@ -35,8 +35,8 @@
       -  ``copper_thickness`` :index:`: <pair: global options; copper_thickness>` [:ref:`number <number>` | :ref:`string <string>`] Copper thickness in micrometers (1 Oz is 35 micrometers).
          KiCad 6: you should set this in the Board Setup -> Physical Stackup.
       -  ``cross_footprints_for_dnp`` :index:`: <pair: global options; cross_footprints_for_dnp>` [:ref:`boolean <boolean>`] (default: ``true``) Draw a cross for excluded components in the `Fab` layer.
-      -  ``cross_no_body`` :index:`: <pair: global options; cross_no_body>` [:ref:`boolean <boolean>`] (default: ``false``) Cross components even when they don't have a body. Only for KiCad 6 and internal cross.
-      -  ``cross_using_kicad`` :index:`: <pair: global options; cross_using_kicad>` [:ref:`boolean <boolean>`] (default: ``true``) When using KiCad 7+ let KiCad cross the components.
+      -  ``cross_no_body`` :index:`: <pair: global options; cross_no_body>` [:ref:`boolean <boolean>`] (default: ``false``) Cross components even when they don't have a body. Only for KiCad 6 and internal cross (Schematic).
+      -  ``cross_using_kicad`` :index:`: <pair: global options; cross_using_kicad>` [:ref:`boolean <boolean>`] (default: ``true``) When using KiCad 7+ let KiCad cross the components (Schematic).
       -  ``csv_accept_no_ref`` :index:`: <pair: global options; csv_accept_no_ref>` [:ref:`boolean <boolean>`] (default: ``false``) Accept aggregating CSV files without references (Experimental).
       -  ``date_format`` :index:`: <pair: global options; date_format>` [:ref:`string <string>`] (default: ``'%Y-%m-%d'``) Format used for the day we started the script.
          Is also used for the PCB/SCH date formatting when `time_reformat` is enabled (default behavior). |br|
@@ -48,6 +48,7 @@
       -  ``dir`` :index:`: <pair: global options; dir>` [:ref:`string <string>`] (default: ``''``) Default pattern for the output directories. It also applies to the preflights, unless
          `use_dir_for_preflights` is disabled.
       -  ``disable_3d_alias_as_env`` :index:`: <pair: global options; disable_3d_alias_as_env>` [:ref:`boolean <boolean>`] (default: ``false``) Disable the use of environment and text variables as 3D models aliases.
+      -  ``disable_kicad_cross_on_fab`` :index:`: <pair: global options; disable_kicad_cross_on_fab>` [:ref:`boolean <boolean>`] (default: ``true``) Disable KiCad cross on Fab layers, so only KiBot does it (KiCad 9+).
       -  ``dnp_cross_bottom_layer`` :index:`: <pair: global options; dnp_cross_bottom_layer>` [:ref:`string <string>`] (default: ``'B.Fab'``) Layer on which to add DNP cross for the bottom components.
       -  ``dnp_cross_top_layer`` :index:`: <pair: global options; dnp_cross_top_layer>` [:ref:`string <string>`] (default: ``'F.Fab'``) Layer on which to add DNP cross for the top components.
       -  ``drc_exclusions_workaround`` :index:`: <pair: global options; drc_exclusions_workaround>` [:ref:`boolean <boolean>`] (default: ``false``) KiCad 6 introduced DRC exclusions. They are stored in the project but ignored by the Python API.

kibot/globals.py

@@ -200,10 +200,12 @@ def __init__(self):
             """ Layer on which to add DNP cross for the top components """
             self.dnp_cross_bottom_layer = 'B.Fab'
             """ Layer on which to add DNP cross for the bottom components """
+            self.disable_kicad_cross_on_fab = True
+            """ Disable KiCad cross on Fab layers, so only KiBot does it (KiCad 9+) """
             self.cross_no_body = False
-            """ Cross components even when they don't have a body. Only for KiCad 6 and internal cross """
+            """ Cross components even when they don't have a body. Only for KiCad 6 and internal cross (Schematic) """
             self.cross_using_kicad = True
-            """ When using KiCad 7+ let KiCad cross the components """
+            """ When using KiCad 7+ let KiCad cross the components (Schematic) """
             self.csv_accept_no_ref = False
             """ Accept aggregating CSV files without references (Experimental) """
             self.date_format = '%Y-%m-%d'

kibot/gs.py

@@ -227,6 +227,8 @@ class GS(object):
     global_kicad_dnp_applies_to_3D = None
     global_cross_using_kicad = None
     global_work_layer = None
+    # Only for KiCad 9+
+    global_disable_kicad_cross_on_fab = None
     pasteable_cmd = shlex.join if hasattr(shlex, 'join') else lambda x: str(x)   # novermin
 
     @staticmethod

kibot/out_any_layer.py

@@ -170,6 +170,8 @@ def run(self, output_dir, layers):
         plot_ctrl = PLOT_CONTROLLER(GS.board)
         # set up plot options for the whole output
         po = plot_ctrl.GetPlotOptions()
+        if GS.global_disable_kicad_cross_on_fab and hasattr(po, "SetCrossoutDNPFPsOnFabLayers"):
+            po.SetCrossoutDNPFPsOnFabLayers(False)
         self._configure_plot_ctrl(po, output_dir)
         # Gerber Job files aren't automagically created
         # We need to assist KiCad

kibot/out_pcb_print.py

@@ -1427,6 +1427,8 @@ def init_plot_controller(self):
         po.SetUseAuxOrigin(False)
         po.SetAutoScale(False)
         GS.SetSvgPrecision(po, self.svg_precision)
+        if GS.global_disable_kicad_cross_on_fab and hasattr(po, "SetCrossoutDNPFPsOnFabLayers"):
+            po.SetCrossoutDNPFPsOnFabLayers(False)
         return pc, po
 
     def set_visible(self, edge_id):