Skip to content

Commit fdc2fab

Browse files
committed
[Panelize][Fixed] vjustify wrong choices (were the same as hjustify)
Fixes #846
1 parent 0906378 commit fdc2fab

5 files changed

Lines changed: 9 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2020
- User.N layer numbering. I.e. pcb_print issues with their numbering (#808)
2121
- KiCost: `kicost_config` not working (#815)
2222
- Huge memory usage for panels (#842)
23+
- Panelize: vjustify wrong choices (were the same as hjustify) (#846)
2324

2425
### Changed
2526
- Filtered KiBot warnings are informed in the debug output (See #817)

docs/samples/generic_plot.kibot.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2946,7 +2946,7 @@ outputs:
29462946
thickness: 0.3
29472947
# [string='none'] [none,simple] Currently fixed. BTW: don't ask me about this ridiculous default, is how KiKit works
29482948
type: 'none'
2949-
# [string='center'] [left,right,center] Vertical justification of the text
2949+
# [string='center'] [top,bottom,center] Vertical justification of the text
29502950
vjustify: 'center'
29512951
# [number|string=0] Specify the vertical offset from anchor. Respects KiCAD coordinate system
29522952
voffset: 0
@@ -2982,7 +2982,7 @@ outputs:
29822982
thickness: 0.3
29832983
# [string='none'] [none,simple] Currently fixed. BTW: don't ask me about this ridiculous default, is how KiKit works
29842984
type: 'none'
2985-
# [string='center'] [left,right,center] Vertical justification of the text
2985+
# [string='center'] [top,bottom,center] Vertical justification of the text
29862986
vjustify: 'center'
29872987
# [number|string=0] Specify the vertical offset from anchor. Respects KiCAD coordinate system
29882988
voffset: 0
@@ -3018,7 +3018,7 @@ outputs:
30183018
thickness: 0.3
30193019
# [string='none'] [none,simple] Currently fixed. BTW: don't ask me about this ridiculous default, is how KiKit works
30203020
type: 'none'
3021-
# [string='center'] [left,right,center] Vertical justification of the text
3021+
# [string='center'] [top,bottom,center] Vertical justification of the text
30223022
vjustify: 'center'
30233023
# [number|string=0] Specify the vertical offset from anchor. Respects KiCAD coordinate system
30243024
voffset: 0
@@ -3054,7 +3054,7 @@ outputs:
30543054
thickness: 0.3
30553055
# [string='none'] [none,simple] Currently fixed. BTW: don't ask me about this ridiculous default, is how KiKit works
30563056
type: 'none'
3057-
# [string='center'] [left,right,center] Vertical justification of the text
3057+
# [string='center'] [top,bottom,center] Vertical justification of the text
30583058
vjustify: 'center'
30593059
# [number|string=0] Specify the vertical offset from anchor. Respects KiCAD coordinate system
30603060
voffset: 0

docs/source/Changelog.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ Fixed
4040
- User.N layer numbering. I.e. pcb_print issues with their numbering
4141
(#808)
4242
- KiCost: ``kicost_config`` not working (#815)
43+
- Huge memory usage for panels (#842)
44+
- Panelize: vjustify wrong choices (were the same as hjustify) (#846)
4345

4446
Changed
4547
~~~~~~~

docs/source/configuration/outputs/PanelizeText.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ PanelizeText parameters
2222
- ``orientation`` :index:`: <pair: output - panelize - options - configs - text4; orientation>` [:ref:`number <number>` | :ref:`string <string>`] (default: ``0``) Specify the orientation (angle).
2323
- ``plugin`` :index:`: <pair: output - panelize - options - configs - text4; plugin>` [:ref:`string <string>`] (default: ``''``) Specify the plugin that provides extra variables for the text.
2424
- ``thickness`` :index:`: <pair: output - panelize - options - configs - text4; thickness>` [:ref:`number <number>` | :ref:`string <string>`] (default: ``0.3``) Stroke thickness.
25-
- ``vjustify`` :index:`: <pair: output - panelize - options - configs - text4; vjustify>` [:ref:`string <string>`] (default: ``'center'``) (choices: "left", "right", "center") Vertical justification of the text.
25+
- ``vjustify`` :index:`: <pair: output - panelize - options - configs - text4; vjustify>` [:ref:`string <string>`] (default: ``'center'``) (choices: "top", "bottom", "center") Vertical justification of the text.
2626
- ``voffset`` :index:`: <pair: output - panelize - options - configs - text4; voffset>` [:ref:`number <number>` | :ref:`string <string>`] (default: ``0``) Specify the vertical offset from anchor. Respects KiCAD coordinate system.
2727
- ``width`` :index:`: <pair: output - panelize - options - configs - text4; width>` [:ref:`number <number>` | :ref:`string <string>`] (default: ``1.5``) Width of the characters (the same parameters as KiCAD uses).
2828

kibot/out_panelize.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ def __init__(self):
426426
self.hjustify = 'center'
427427
""" [left,right,center] Horizontal justification of the text """
428428
self.vjustify = 'center'
429-
""" [left,right,center] Vertical justification of the text """
429+
""" [top,bottom,center] Vertical justification of the text """
430430
self.thickness = 0.3
431431
""" [number|string=0.3] Stroke thickness """
432432
self.layer = 'F.SilkS'

0 commit comments

Comments
 (0)