Skip to content

fix(out_base): update 3D variant aspect matching logic #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
set-soft merged 1 commit into from
May 19, 2025
Merged

fix(out_base): update 3D variant aspect matching logic #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kibot/out_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,13 +758,14 @@ def apply_3D_variant_aspect(self, board, enable=False):
logger.debug(f" - Variant specific: {text}")
var = match.group(1)
slots = match.group(2).split(',') if match.group(2) else []

# Do the match
matched = self.variant.matches_variant(var)
if matched:
self.apply_list_of_3D_models(enable, slots, m, var)
break
if not matched and default is not None:
self.apply_list_of_3D_models(enable, slots, m, '_default_')
self.apply_list_of_3D_models(enable, default, m, '_default_')
Copy link
Copy Markdown
Member

@set-soft set-soft May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this enough?

Copy link
Copy Markdown
Author

@mdeweerd mdeweerd May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote "I think technically there can be even less" and explained why I prefer to keep the other changes as well.


def create_3D_highlight_file(self):
if self._highlight_3D_file:
Expand Down
Loading