fix: make --fail-on-warnings respect filters by default#893
Merged
Conversation
oliv3r
force-pushed
the
filtered_warnings
branch
from
57e08fd to
ebb0c98
Compare
The current implementation of `--fail-on-warnings` triggers a failure (39) on any warning, ignoring the filtering system. This change aligns `--fail-on-warnings` with the logic of `--fail-on-ignored` (-F). * By default, only unfiltered (unique) warnings trigger a failure. * If `--fail-on-ignored` is active, any warning (including filtered ones) will trigger the failure. See INTI-CMNB#828 Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
oliv3r
force-pushed
the
filtered_warnings
branch
from
ebb0c98 to
7648d4e
Compare
Member
|
Ok, this is coherent with the help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
--fail-on-warningstriggers a failure (39)on any warning, ignoring the filtering system.
This change aligns
--fail-on-warningswith the logic of--fail-on-ignored(-F).--fail-on-ignoredis active, any warning (including filteredones) will trigger the failure.
See #828