Skip to content

Commit 2e0d407

Browse files
fix(Makefile): use $(MAKE) for recursive build in build_nc_theming_app
Plain 'make build_css' inside the recipe is the wrong form for a recursive build: it doesn't inherit the jobserver from the parent make invocation, so when the Makefile is driven with 'make -j' (or from a parent build that already holds jobserver tokens) the inner make either prints 'warning: jobserver unavailable' or silently loses parallel scheduling. Replace it with $(MAKE), which GNU Make documents as the canonical form for recursive invocations — it propagates MAKEFLAGS, jobserver tokens, and triggers the recursive-make detection that prints 'make[1]: Entering directory ...' on entry. Caught by GitHub Copilot in PR 109 review: #109 (comment)
1 parent 1d0ddfb commit 2e0d407

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ $(EXTERNAL_FULL_TARGETS): build_%_app:
169169
build_nc_theming_app: ## Build the custom css
170170
@echo "[i] Building nc_theming app..."
171171
cd apps-custom/nc_theming && \
172-
make build_css
172+
$(MAKE) build_css
173173
@echo "[✓] nc_theming app built successfully"
174174

175175
build_nc-ionos-theme_app: ## Install and build ionos theme

0 commit comments

Comments
 (0)