feat: Add env-based OIDC logout URI mapping#130
Merged
Conversation
Compute logout endpoints from INSTANCE_TYPE and MARKET, and merge them into user_oidc config. Log a warning when no mapping exists. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Merged
2 tasks
There was a problem hiding this comment.
Pull request overview
This PR makes the OIDC logout endpoints configurable based on runtime environment (INSTANCE_TYPE and MARKET) by computing a logout-URI mapping at config-load time and merging it into the user_oidc config, while emitting a warning when no mapping exists.
Changes:
- Compute
endsessionendpointuri/postlogouturifromINSTANCE_TYPE+MARKET. - Merge the computed logout URI pair into the existing
user_oidcconfiguration. - Log a warning when there is no mapping for the detected environment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+55
to
+61
| if ($uris === []) { | ||
| error_log(sprintf( | ||
| 'oidc.config.php: no logout URIs for INSTANCE_TYPE=%s MARKET=%s', | ||
| $instanceType, | ||
| $market, | ||
| )); | ||
| } |
lara-fernandezcueto
requested changes
Jul 1, 2026
lara-fernandezcueto
left a comment
lara-fernandezcueto
left a comment
There was a problem hiding this comment.
It looks good except for the empty check
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute logout endpoints from INSTANCE_TYPE and MARKET, and merge them into user_oidc config. Log a warning when no mapping exists.