fix: Ensure edit permissions are checked before template file token g…#1
Merged
Merged
Conversation
printminion-co
force-pushed
the
fix/respect_edit_groups_for_templates
branch
2 times, most recently
from
ab063d1 to
46e2fa8
Compare
printminion-co
force-pushed
the
fix/respect_edit_groups_for_templates
branch
4 times, most recently
from
572d57a to
89ff3a7
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
printminion-co
force-pushed
the
fix/respect_edit_groups_for_templates
branch
from
89ff3a7 to
9222570
Compare
…eneration otherwise file created from template will be editable for user with readonly permissions Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Co-authored-by: Julius Knorr <jus@bitgrid.net> Signed-off-by: Mikhailo Matiyenko-Kupriyanov <145785698+printminion-co@users.noreply.github.com>
printminion-co
force-pushed
the
fix/respect_edit_groups_for_templates
branch
from
0aa4ba6 to
7878dd3
Compare
printminion-co
pushed a commit
that referenced
this pull request
Mar 11, 2026
This fixed the follow warning: ``` json_decode(): Passing null to parameter #1 ($json) of type string is deprecated at /var/www/html/apps-extra/richdocuments/lib/Service/CapabilitiesService.php#142 ``` The method `get` return string|null Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
printminion-co
pushed a commit
that referenced
this pull request
Mar 11, 2026
This fixed the follow warning: ``` json_decode(): Passing null to parameter #1 ($json) of type string is deprecated at /var/www/html/apps-extra/richdocuments/lib/Service/CapabilitiesService.php#142 ``` The method `get` return string|null Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
printminion-co
pushed a commit
that referenced
this pull request
May 5, 2026
…nt paths When shouldSecure() is called with tryOpen=true on a path that does not exist yet (e.g. a rename target or a files_versions snapshot path), the underlying fopen() call returns false. Calling fclose(false) on that value throws a TypeError in PHP 8, which propagates as an uncaught exception and aborts the entire DAV operation with HTTP 500. To reproduce: enable Secure View watermarking for a group, add your user to that group, then rename or overwrite any Office document. The rename fails immediately with HTTP 500 and the following error appears in nextcloud.log: fclose(): Argument #1 ($stream) must be of type resource, bool given in …/richdocuments/lib/Service/SecureViewService.php:37 Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
printminion-co
pushed a commit
that referenced
this pull request
May 5, 2026
…nt paths When shouldSecure() is called with tryOpen=true on a path that does not exist yet (e.g. a rename target or a files_versions snapshot path), the underlying fopen() call returns false. Calling fclose(false) on that value throws a TypeError in PHP 8, which propagates as an uncaught exception and aborts the entire DAV operation with HTTP 500. To reproduce: enable Secure View watermarking for a group, add your user to that group, then rename or overwrite any Office document. The rename fails immediately with HTTP 500 and the following error appears in nextcloud.log: fclose(): Argument #1 ($stream) must be of type resource, bool given in …/richdocuments/lib/Service/SecureViewService.php:37 Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
printminion-co
pushed a commit
that referenced
this pull request
May 5, 2026
…nt paths When shouldSecure() is called with tryOpen=true on a path that does not exist yet (e.g. a rename target or a files_versions snapshot path), the underlying fopen() call returns false. Calling fclose(false) on that value throws a TypeError in PHP 8, which propagates as an uncaught exception and aborts the entire DAV operation with HTTP 500. To reproduce: enable Secure View watermarking for a group, add your user to that group, then rename or overwrite any Office document. The rename fails immediately with HTTP 500 and the following error appears in nextcloud.log: fclose(): Argument #1 ($stream) must be of type resource, bool given in …/richdocuments/lib/Service/SecureViewService.php:37 Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eneration
otherwise file created from template will be editable for user with readonly permissions
wait for nextcloud#4698 to be resolved
Summary
TODO
Checklist