Kh/dev/remove fa v30#266
Merged
Merged
Conversation
Remove all four custom-npm submodules that existed solely to support the Font Awesome icon embedding pipeline: - nc-mdi-svg: FA-to-MDI SVG embedding (primary FA integration point) - nc-mdi-js: thin wrapper over @mdi/js, only customized to use nc-mdi-svg - nc-nextcloud-vue: thin fork of @nextcloud/vue, only wired custom icon packages - nc-vue-material-design-icons: FA mapping logic, now redundant without FA Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
hidrive-next-build.yml: remove custom-npms/** path trigger and FONTAWESOME_PACKAGE_TOKEN from the build step. sbom-matrix.yaml: remove FONTAWESOME_PACKAGE_TOKEN secret requirement and custom-npm pre-install steps from the npm install job. Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
Revert d35db04 Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de> Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/remove-FA-v30
branch
from
11e9c3e to
d402e4e
Compare
tanyaka
requested changes
Jun 19, 2026
There was a problem hiding this comment.
Review OK for:
Changes reqired (feedback in PRs) for:
see feedback to apps/files/src/components/FilesListVirtual.vue in this PR.
We should check if we still using hardcoded FA icons in https://github.com/IONOS-Productivity/nc-ionos-theme/blob/main/IONOS/src/components/Icon.svelte Feel free to add a subtask.
bromiesTM
force-pushed
the
kh/dev/remove-FA-v30
branch
2 times, most recently
from
3d77dd7 to
191903b
Compare
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/remove-FA-v30
branch
from
191903b to
72ca15c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.