build(Makefile): update gdata to gdatavaas in apps list#126
Draft
printminion-co wants to merge 2 commits into
Draft
build(Makefile): update gdata to gdatavaas in apps list#126printminion-co wants to merge 2 commits into
printminion-co wants to merge 2 commits into
Conversation
This change updates the application list in the Makefile to replace 'gdata_antivirus' with 'gdatavaas', reflecting the new application configuration. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
6 tasks
Add configure_gdatavaas_app() function to configure.sh that enables and configures the GDATA VaaS antivirus app via OCC commands. https://github.com/GDATASoftwareAG/nextcloud-gdata-antivirus?tab=readme-ov-file#configuring-via-the-command-line Features: - Conditional enablement via APP_GDATAVAAS_ENABLED flag - Supports both ResourceOwnerPassword and ClientCredentials auth methods - Configures all GDATA VaaS settings with sensible defaults - Handles sensitive credentials with --sensitive flag - Validates required environment variables per auth method - Uses set_app_config_typed() for proper type handling Configuration includes: - Authentication (username/password or clientId/clientSecret) - VaaS and token endpoint URLs (defaults to staging) - Quarantine folder settings - Auto-scan and file tagging options - Scan filters (allowlist/blocklist) - Email notifications for infected files - Scan limits (max file size, timeout) - Caching and hash lookup options All environment variables follow APP_GDATAVAAS_* naming convention as documented in JIRA ticket for helm chart integration. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the application list in the Makefile to replace 'gdata_antivirus' with 'gdatavaas', reflecting the new application configuration.