fix: Allow URLs without explicit port for whiteboard config#157
Merged
Conversation
Signed-off-by: Aliza Held <aliza.held@strato.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the deployment/configuration script so the whiteboard app's collabBackendUrl can be assembled conditionally instead of always forcing a port suffix. This fits into the repo's bootstrap flow by adjusting how app settings are written during configure.sh.
Changes:
- Adds conditional logic in
configure_whiteboard_app()before composingcollabBackendUrl. - Switches the whiteboard OCC config call to use the computed URL value directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
seriAlizations
force-pushed
the
ah/dev/whiteboard-allow-empty-ports
branch
from
ae7353d to
9bb848e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+434
to
+435
| _collab_backend_port="${APP_WHITEBOARD_COLLABBACKEND_PORT:-3002}" | ||
| if [ "${_collab_backend_port}" != "-" ]; then |
seriAlizations
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For whiteboard backend to be able to connect, we need to configure.sh to allow urls without explicit port also.