Skip to content

Fix CACHE_VERSION access in bash script context#131

Closed
printminion-co with Copilot wants to merge 5 commits into
mk/poc/dont_rebuild_already_built_appsfrom
copilot/sub-pr-127-again
Closed

Fix CACHE_VERSION access in bash script context#131
printminion-co with Copilot wants to merge 5 commits into
mk/poc/dont_rebuild_already_built_appsfrom
copilot/sub-pr-127-again

Conversation

Copilot AI commented Nov 13, 2025

Copy link
Copy Markdown

Summary

The CACHE_VERSION environment variable was inaccessible in the bash script that generates cache keys. GitHub Actions expressions like ${{ env.CACHE_VERSION }} are not evaluated inside run: blocks, causing malformed cache keys.

Changes:

  • Pass CACHE_VERSION as environment variable to the "Collect apps and their SHAs" step
  • Update bash script to reference $CACHE_VERSION instead of ${{ env.CACHE_VERSION }}
  - name: Collect apps and their SHAs for cache-based building
    id: detect
    env:
      GH_TOKEN: ${{ github.token }}
+     CACHE_VERSION: ${{ env.CACHE_VERSION }}
    run: |
      ...
-     CACHE_KEY="${{ env.CACHE_VERSION }}-app-build-${APP_NAME}-${CURRENT_SHA}"
+     CACHE_KEY="${CACHE_VERSION}-app-build-${APP_NAME}-${CURRENT_SHA}"

TODO

  • Fix CACHE_VERSION access in bash context

Checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

printminion-co and others added 3 commits November 13, 2025 13:00
Optimized build workflow that uses cache-based detection
 - Checks cache for each app's current SHA
 - Only builds apps with no cached build
 - Significantly reduces build time through smart caching

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Mikhailo Matiyenko-Kupriyanov <145785698+printminion-co@users.noreply.github.com>
Copilot AI self-assigned this Nov 13, 2025
Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on preventing rebuild of already built apps Fix CACHE_VERSION access in bash script context Nov 13, 2025
Copilot AI requested a review from printminion-co November 13, 2025 12:09
@printminion-co printminion-co deleted the copilot/sub-pr-127-again branch November 13, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants