IONOS(CI): Pin GitHub Actions in build workflow#314
Merged
Conversation
Replace floating action versions with pinned commit SHAs in .github/workflows/build-artifact.yml and update referenced releases, including JFrog and Docker actions, to improve supply chain security and reproducibility Signed-off-by: Kai Henseler <kai.henseler@strato.de>
There was a problem hiding this comment.
Pull request overview
Pins third-party GitHub Actions in the build-artifact workflow to specific commit SHAs to improve supply-chain security and reproducibility.
Changes:
- Replaces floating action refs (e.g.,
@v4,@v5,@v6) with pinned commit SHAs across the workflow. - Updates several actions to newer major versions while pinning (e.g., checkout/cache/artifact actions, docker actions).
- Minor whitespace cleanup in the build type computation.
Comments suppressed due to low confidence (1)
.github/workflows/build-artifact.yml:486
- This workflow now uses
jfrog/setup-jfrog-cliv5.0.0 inbuild-artifact, but other jobs in the same workflow still use v4.4.1 (e.g. thebuild-external-appsandPush to artifactoryjobs). Mixing major versions can make thejfcommand behavior differ between jobs and complicate troubleshooting; consider standardizing on one version across the workflow (either upgrade the other steps to v5 as well, or keep this step on v4.4.1).
- name: Setup JFrog CLI
uses: jfrog/setup-jfrog-cli@1641575d87647fb969c0545f0b6a76873e328b7c # v5.0.0
env:
JF_URL: ${{ secrets.JF_ARTIFACTORY_URL }}
JF_USER: ${{ secrets.JF_ARTIFACTORY_USER }}
JF_ACCESS_TOKEN: ${{ secrets.JF_ACCESS_TOKEN }}
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 7.0.0 |
As github phases out Node.js 20 see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ Signed-off-by: Kai Henseler <kai.henseler@strato.de>
8736108 to
ac19afb
Compare
Arsalanulhaq
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.