Skip to content

Commit 2f0ded8

Browse files
committed
fix: remove "excludeFiles" flag from "Get Dataset Versions" use case
1 parent cd2a196 commit 2f0ded8

4 files changed

Lines changed: 4 additions & 13 deletions

File tree

docs/useCases.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,6 @@ _See [use case](../src/datasets/domain/useCases/GetDatasetVersions.ts) implement
900900
- **limit**: (number) Limit for pagination.
901901
- **offset**: (number) Offset for pagination.
902902
- **excludeMetadataBlocks**: (boolean) Exclude metadata blocks (default: false).
903-
- **excludesFiles**: (boolean) Exclude files (default: true).
904903

905904
#### Get Dataset Versions Summaries
906905

src/datasets/domain/repositories/IDatasetsRepository.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ export interface IDatasetsRepository {
7878
datasetId: number | string,
7979
limit?: number,
8080
offset?: number,
81-
excludeMetadataBlocks?: boolean,
82-
excludeFiles?: boolean
81+
excludeMetadataBlocks?: boolean
8382
): Promise<DatasetVersionSubset>
8483
deleteDatasetDraft(datasetId: number | string): Promise<void>
8584
linkDataset(datasetId: number | string, collectionIdOrAlias: number | string): Promise<void>

src/datasets/domain/useCases/GetDatasetVersions.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,14 @@ export class GetDatasetVersions implements UseCase<DatasetVersionSubset> {
1717
* @param {number} [limit] - Limit for pagination (optional).
1818
* @param {number} [offset] - Offset for pagination (optional).
1919
* @param {boolean} [excludeMetadataBlocks] - Exclude metadata blocks (optional, default: false).
20-
* @param {boolean} [excludeFiles] - Exclude files (optional, default: true).
2120
* @returns {Promise<DatasetVersionSubset>} - A DatasetVersionSubset containing the versions and total count.
2221
*/
2322
async execute(
2423
datasetId: number | string,
2524
limit?: number,
2625
offset?: number,
27-
excludeMetadataBlocks?: boolean,
28-
excludeFiles?: boolean
26+
excludeMetadataBlocks?: boolean
2927
): Promise<DatasetVersionSubset> {
30-
return await this.datasetsRepository.getDatasetVersions(datasetId, limit, offset, excludeMetadataBlocks, excludeFiles)
28+
return await this.datasetsRepository.getDatasetVersions(datasetId, limit, offset, excludeMetadataBlocks)
3129
}
3230
}

src/datasets/infra/repositories/DatasetsRepository.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,7 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
342342
datasetId: string | number,
343343
limit?: number,
344344
offset?: number,
345-
excludeMetadataBlocks?: boolean,
346-
excludeFiles?: boolean
345+
excludeMetadataBlocks?: boolean
347346
): Promise<DatasetVersionSubset> {
348347
const queryParams = new URLSearchParams()
349348

@@ -359,10 +358,6 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
359358
queryParams.set('excludeMetadataBlocks', excludeMetadataBlocks.toString())
360359
}
361360

362-
if (excludeFiles !== undefined) {
363-
queryParams.set('excludeFiles', excludeFiles.toString())
364-
}
365-
366361
return this.doGet(
367362
this.buildApiEndpoint(this.datasetsResourceName, 'versions', datasetId),
368363
true,

0 commit comments

Comments
 (0)