Skip to content

Commit cd2a196

Browse files
committed
fix: remove "isInReviewState" flag from dataset versions
1 parent 6de066f commit cd2a196

3 files changed

Lines changed: 0 additions & 6 deletions

File tree

src/datasets/domain/models/DatasetVersion.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export interface DatasetVersion {
1212
versionMinorNumber?: number
1313
internalVersionNumber: number
1414
versionState: DatasetVersionState
15-
isInReviewState: boolean
1615
latestVersionPublishingState: DatasetVersionState
1716
lastUpdateTime: string
1817
releaseTime?: string

test/integration/datasets/DatasetsRepository.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1580,7 +1580,6 @@ describe('DatasetsRepository', () => {
15801580
expect(actual.totalCount).toBeGreaterThan(0)
15811581
expect(actual.versions[0].versionState).toBe('DRAFT')
15821582
expect(actual.versions[0].latestVersionPublishingState).toBe('DRAFT')
1583-
expect(actual.versions[0].isInReviewState).toBe(false)
15841583

15851584
await deleteUnpublishedDatasetViaApi(testDatasetIds.numericId)
15861585
})
@@ -1601,7 +1600,6 @@ describe('DatasetsRepository', () => {
16011600
expect(actual.versions[0].versionNumber).toBe(1)
16021601
expect(actual.versions[0].versionMinorNumber).toBe(0)
16031602
expect(actual.versions[0].versionState).toBe('RELEASED')
1604-
expect(actual.versions[0].isInReviewState).toBe(false)
16051603

16061604
await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
16071605
})
@@ -1624,7 +1622,6 @@ describe('DatasetsRepository', () => {
16241622
expect(actual.versions[0].versionNumber).toBe(1)
16251623
expect(actual.versions[0].versionMinorNumber).toBe(0)
16261624
expect(actual.versions[0].versionState).toBe('DEACCESSIONED')
1627-
expect(actual.versions[0].isInReviewState).toBe(false)
16281625

16291626
await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
16301627
})
@@ -1664,7 +1661,6 @@ describe('DatasetsRepository', () => {
16641661
expect(actual.versions.length).toEqual(2)
16651662
expect(actual.totalCount).toEqual(2)
16661663
expect(actual.versions[0].versionState).toBe('DRAFT')
1667-
expect(actual.versions[0].isInReviewState).toBe(false)
16681664

16691665
expect(actual.versions[1].versionNumber).toBe(1)
16701666
expect(actual.versions[1].versionMinorNumber).toBe(0)

test/testHelpers/datasets/datasetVersionsHelper.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export const createDatasetVersionModel = (
1111
internalVersionNumber: 1,
1212
versionState: DatasetVersionState.DRAFT,
1313
latestVersionPublishingState: DatasetVersionState.DRAFT,
14-
isInReviewState: false,
1514
lastUpdateTime: '2021-01-01T00:00:00Z',
1615
createTime: '2021-01-01T00:00:00Z',
1716
publicationDate: '2021-01-01',

0 commit comments

Comments
 (0)