Skip to content

tests fix #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jp-tosca wants to merge 2 commits into from
Closed

tests fix #443

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352522b
tests fix
jp-tosca Apr 23, 2026
6dc8eb8
tests fix
jp-tosca Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/collections/CollectionsRepository.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ describe('CollectionsRepository', () => {

describe('getCollectionItems for published tabular file', () => {
let testDatasetIds: CreatedDatasetIdentifiers
const testTextFile4Name = 'test-file-4.tab'
const testTextFile4Name = 'test-file-4.tsv'

Copilot AI Apr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testTextFile4Name was changed to test-file-4.tsv, but the test fixture that uploadFileViaApi reads from test/testHelpers/files is test-file-4.tab (no .tsv exists). This will cause readFile(${__dirname}/${fileName}) to fail and also makes the later expectation expectedFileName = 'test-file-4.tab' inconsistent. Either revert to .tab or add the .tsv fixture and update the expected filename/assertions accordingly.

Suggested change
const testTextFile4Name = 'test-file-4.tsv'
const testTextFile4Name = 'test-file-4.tab'

Copilot uses AI. Check for mistakes.
const testSubCollectionAlias = 'collectionsRepositoryTestSubCollection'

beforeAll(async () => {
Expand Down
Loading