feat: disallow guestbook if it's a draft or edit permission

Author: ChengShi-1

package-lock.json

@@ -18,7 +18,7 @@
     "@dnd-kit/sortable": "8.0.0",
     "@dnd-kit/utilities": "3.2.2",
     "@faker-js/faker": "7.6.0",
-    "@iqss/dataverse-client-javascript": "2.1.0-alpha.2",
+    "@iqss/dataverse-client-javascript": "2.1.0-pr438.62748a8",
     "@iqss/dataverse-design-system": "*",
     "@istanbuljs/nyc-config-typescript": "1.0.2",
     "@tanstack/react-table": "8.9.2",

package.json

@@ -12,6 +12,7 @@ export { NavbarDropdown } from './components/navbar/navbar-dropdown/NavbarDropdo
 export { ThemeProvider, useTheme } from './components/theme/ThemeProvider'
 export { Breadcrumb } from './components/breadcrumb/Breadcrumb'
 export { Alert } from './components/alert/Alert'
+export type { AlertVariant } from './components/alert/AlertVariant'
 export { Tabs } from './components/tabs/Tabs'
 export { Accordion } from './components/accordion/Accordion'
 export { ButtonGroup } from './components/button-group/ButtonGroup'

packages/design-system/src/lib/index.ts

@@ -11,11 +11,11 @@
     "forceConsistentCasingInFileNames": true,
     "noFallthroughCasesInSwitch": true,
     "module": "esnext",
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "resolveJsonModule": true,
     "isolatedModules": true,
     "noEmit": true,
-    "jsx": "react-jsx"
+    "jsx": "react-jsx"   
   },
   "include": ["src", "tests", "vite.config.ts", "cypress.config.ts", ".storybook/test-runner.ts"],
   "exclude": ["tests/**/**.spec.ts", "tests/**/**.spec.tsx"]

packages/design-system/tsconfig.json

@@ -1,4 +1,4 @@
-import { AlertVariant } from '@iqss/dataverse-design-system/dist/components/alert/AlertVariant'
+import { type AlertVariant } from '@iqss/dataverse-design-system'
 
 export enum AlertMessageKey {
   DRAFT_VERSION = 'draftVersion',

src/alert/domain/models/Alert.ts

@@ -6,6 +6,7 @@ export interface GuestbookOption {
 }
 
 export interface GuestbookCustomQuestion {
+  id?: number | string
   question: string
   required: boolean
   displayOrder: number

src/guestbooks/domain/models/Guestbook.ts

@@ -51,7 +51,10 @@ export function AccessDatasetMenu({
   const [selectedDownloadFormat, setSelectedDownloadFormat] = useState<FileDownloadMode>(
     FileDownloadMode.ORIGINAL
   )
-  const hasGuestbook = guestbookId !== undefined
+  const hasGuestbook =
+    guestbookId !== undefined &&
+    version.publishingStatus !== DatasetPublishingStatus.DRAFT &&
+    !permissions.canUpdateDataset
 
   const flesToDownloadSizeIsZero =
     fileDownloadSizes.map(({ value }) => value).reduce((acc, curr) => acc + curr, 0) === 0

src/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.tsx

@@ -3,6 +3,7 @@ import { useTranslation } from 'react-i18next'
 import { Button, DropdownButton, DropdownButtonItem } from '@iqss/dataverse-design-system'
 import { MouseEvent, useState } from 'react'
 import { toast } from 'react-toastify'
+import { DatasetPublishingStatus } from '@/dataset/domain/models/Dataset'
 import { FileDownloadMode } from '../../../../../../files/domain/models/FileMetadata'
 import { useDataset } from '../../../../DatasetContext'
 import { FileSelection } from '../../row-selection/useFileSelection'
@@ -42,7 +43,10 @@ export function DownloadFilesButton({ files, fileSelection }: DownloadFilesButto
   const fileIdsForGuestbookSubmission = allFilesSelected
     ? undefined
     : getFileIdsFromSelection(fileSelection)
-  const hasGuestbook = dataset?.guestbookId !== undefined
+  const hasGuestbook =
+    dataset?.guestbookId !== undefined &&
+    dataset?.version.publishingStatus !== DatasetPublishingStatus.DRAFT &&
+    !dataset?.permissions.canUpdateDataset
 
   const onClick = (event: MouseEvent<HTMLElement>, downloadMode: FileDownloadMode) => {
     if (fileSelectionCount === SELECTED_FILES_EMPTY) {

src/sections/dataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.tsx

@@ -31,6 +31,8 @@ export function FileActionButtons({
         userHasDownloadPermission={file.permissions.canDownloadFile}
         metadata={file.metadata}
         isDeaccessioned={file.datasetPublishingStatus === DatasetPublishingStatus.DEACCESSIONED}
+        isDraft={file.datasetPublishingStatus === DatasetPublishingStatus.DRAFT}
+        canEdit={file.permissions.canEditOwnerDataset}
         ingestInProgress={file.ingest.isInProgress}
         asIcon
       />

src/sections/dataset/dataset-files/files-table/file-actions/file-actions-cell/file-action-buttons/FileActionButtons.tsx

@@ -153,6 +153,8 @@ export function File({
                   metadata={file.metadata}
                   ingestInProgress={file.ingest.isInProgress}
                   isDeaccessioned={isDeaccessioned}
+                  isDraft={file.datasetVersion.publishingStatus === DatasetPublishingStatus.DRAFT}
+                  canEdit={file.permissions.canEditOwnerDataset}
                   guestbookId={file.guestbookId}
                   datasetPersistentId={file.datasetPersistentId}
                   datasetLicense={file.datasetLicense}