fix: permission has to change in tests

Author: ChengShi-1

tests/component/dataset/domain/models/DatasetMother.ts

@@ -158,6 +158,12 @@ export class DatasetPermissionsMother {
     return this.create({ canDownloadFiles: true })
   }
 
+  static createWithFilesDownloadAllowedButNotUpdatePermissions(): DatasetPermissions {
+    return this.create({
+      canDownloadFiles: true,
+      canUpdateDataset: false
+    })
+  }
   static createWithFilesDownloadNotAllowed(): DatasetPermissions {
     return this.create({ canDownloadFiles: false })
   }

tests/component/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.spec.tsx

@@ -289,10 +289,8 @@ describe('AccessDatasetMenu', () => {
 
   it('opens DownloadWithGuestbookModal when guestbook exists and download option is clicked', () => {
     const version = DatasetVersionMother.createReleased()
-    const permissions = DatasetPermissionsMother.create({
-      canDownloadFiles: true,
-      canUpdateDataset: false
-    })
+    const permissions =
+      DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions()
     const fileDownloadSizes = [
       DatasetFileDownloadSizeMother.createOriginal({ value: 2000, unit: FileSizeUnit.BYTES })
     ]
@@ -347,10 +345,8 @@ describe('AccessDatasetMenu', () => {
 
   it('does not fetch the guestbook until the modal is opened', () => {
     const version = DatasetVersionMother.createReleased()
-    const permissions = DatasetPermissionsMother.create({
-      canDownloadFiles: true,
-      canUpdateDataset: false
-    })
+    const permissions =
+      DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions()
     const fileDownloadSizes = [
       DatasetFileDownloadSizeMother.createOriginal({ value: 2000, unit: FileSizeUnit.BYTES })
     ]
@@ -394,10 +390,8 @@ describe('AccessDatasetMenu', () => {
 
   it('renders download option as a button and opens guestbook modal when guestbook exists', () => {
     const version = DatasetVersionMother.createReleased()
-    const permissions = DatasetPermissionsMother.create({
-      canDownloadFiles: true,
-      canUpdateDataset: false
-    })
+    const permissions =
+      DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions()
 
     const fileDownloadSizes = [
       DatasetFileDownloadSizeMother.createOriginal({ value: 2000, unit: FileSizeUnit.BYTES })
@@ -441,7 +435,8 @@ describe('AccessDatasetMenu', () => {
 
   it('closes DownloadWithGuestbookModal when cancel is clicked', () => {
     const version = DatasetVersionMother.createReleased()
-    const permissions = DatasetPermissionsMother.createWithFilesDownloadAllowed()
+    const permissions =
+      DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions()
     const fileDownloadSizes = [
       DatasetFileDownloadSizeMother.createOriginal({ value: 2000, unit: FileSizeUnit.BYTES })
     ]
@@ -484,7 +479,8 @@ describe('AccessDatasetMenu', () => {
 
   it('opens guestbook modal from archival option when guestbook exists', () => {
     const version = DatasetVersionMother.createReleased()
-    const permissions = DatasetPermissionsMother.createWithFilesDownloadAllowed()
+    const permissions =
+      DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions()
     const fileDownloadSizes = [
       DatasetFileDownloadSizeMother.createOriginal({ value: 2000, unit: FileSizeUnit.BYTES }),
       DatasetFileDownloadSizeMother.createArchival({ value: 4000, unit: FileSizeUnit.BYTES })

tests/component/sections/dataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.spec.tsx

@@ -397,7 +397,7 @@ describe('DownloadFilesButton', () => {
 
   it('opens guestbook modal when guestbook exists and files are selected for non-tabular download', () => {
     const datasetWithGuestbook = DatasetMother.create({
-      permissions: DatasetPermissionsMother.createWithFilesDownloadAllowed(),
+      permissions: DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions(),
       hasOneTabularFileAtLeast: false,
       guestbookId: 10
     })
@@ -423,7 +423,7 @@ describe('DownloadFilesButton', () => {
 
   it('opens guestbook modal when guestbook exists and tabular option is clicked', () => {
     const datasetWithGuestbook = DatasetMother.create({
-      permissions: DatasetPermissionsMother.createWithFilesDownloadAllowed(),
+      permissions: DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions(),
       hasOneTabularFileAtLeast: true,
       guestbookId: 10
     })
@@ -449,7 +449,7 @@ describe('DownloadFilesButton', () => {
 
   it('does not fetch the guestbook until the modal is opened', () => {
     const datasetWithGuestbook = DatasetMother.create({
-      permissions: DatasetPermissionsMother.createWithFilesDownloadAllowed(),
+      permissions: DatasetPermissionsMother.createWithFilesDownloadAllowedButNotUpdatePermissions(),
       hasOneTabularFileAtLeast: true,
       guestbookId: 10
     })

tests/e2e-integration/e2e/sections/collection/CollectionItemsPanel.spec.ts

@@ -74,7 +74,7 @@ describe('Collection Items Panel', () => {
   })
 
   it('performs different search, filtering and respond to back and forward navigation', () => {
-    cy.visit(`/spa/collections/${collectionId}`)
+    cy.visit(`/spa/collections`)
 
     cy.wait('@getCollectionItems').then((interception) => {
       const { totalItemsInResponse, collectionsInResponse, datasetsInResponse, filesInResponse } =
@@ -124,7 +124,7 @@ describe('Collection Items Panel', () => {
         ].join(',')
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${firstExpectedURL}`)
+      cy.url().should('include', `/collections?${firstExpectedURL}`)
     })
 
     // 2 - Now perform a search in the input
@@ -157,7 +157,7 @@ describe('Collection Items Panel', () => {
         [CollectionItemsQueryParams.QUERY]: 'Darwin'
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${secondExpectedURL}`)
+      cy.url().should('include', `/collections?${secondExpectedURL}`)
     })
 
     // 3 - Clear the search and assert that the search is performed correctly and the url is updated correctly
@@ -190,7 +190,7 @@ describe('Collection Items Panel', () => {
         ].join(',')
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${thirdExpectedURL}`)
+      cy.url().should('include', `/collections?${thirdExpectedURL}`)
     })
 
     // 4 - Uncheck the Collections checkbox
@@ -222,7 +222,7 @@ describe('Collection Items Panel', () => {
         ].join(',')
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${fourthExpectedURL}`)
+      cy.url().should('include', `/collections?${fourthExpectedURL}`)
     })
 
     // 5 - Uncheck the Dataset checkbox
@@ -250,7 +250,7 @@ describe('Collection Items Panel', () => {
         [CollectionItemsQueryParams.TYPES]: [CollectionItemType.FILE].join(',')
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${fifthExpectedURL}`)
+      cy.url().should('include', `/collections?${fifthExpectedURL}`)
     })
 
     // 6 - Navigate back with the browser and assert that the url is updated correctly and the items are displayed correctly as in step 4
@@ -281,7 +281,7 @@ describe('Collection Items Panel', () => {
         ].join(',')
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${fourthExpectedURL}`)
+      cy.url().should('include', `/collections?${fourthExpectedURL}`)
     })
 
     // 7 - Selects a facet filter
@@ -315,7 +315,7 @@ describe('Collection Items Panel', () => {
         ].join(',')
       }).toString()
 
-      cy.url().should('include', `/collections/${collectionId}?${expectedURL}`)
+      cy.url().should('include', `/collections?${expectedURL}`)
 
       // Assert that the selected facet filter is displayed
       cy.findAllByRole('button', { name: /Finch, Fiona/ })