Skip to content

Commit e7769b4

Browse files
authored
Merge pull request #757 from IQSS/752-dataset-page-hide-deaccessioned-button
Dataset Page: hide deaccessioned button if the current version is Deaccessioned
2 parents 3228ecc + f0cfba4 commit e7769b4

2 files changed

Lines changed: 20 additions & 1 deletion

File tree

src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export function EditDatasetMenu({ dataset, datasetRepository }: EditDatasetMenuP
3535
const { t } = useTranslation('dataset')
3636
const navigate = useNavigate()
3737
const { showModal } = useNotImplementedModal()
38+
const isDeaccessioned = dataset.version.publishingStatus === DatasetPublishingStatus.DEACCESSIONED
3839

3940
const handleOnSelect = (eventKey: EditDatasetMenuItems | string | null) => {
4041
const searchParams = new URLSearchParams()
@@ -110,7 +111,9 @@ export function EditDatasetMenu({ dataset, datasetRepository }: EditDatasetMenuP
110111
{t('datasetActionButtons.editDataset.thumbnailsPlusWidgets')}
111112
</DropdownButtonItem>
112113
<DeleteDraftDatasetButton dataset={dataset} datasetRepository={datasetRepository} />
113-
<DeaccessionDatasetButton datasetRepository={datasetRepository} dataset={dataset} />
114+
{!isDeaccessioned && (
115+
<DeaccessionDatasetButton datasetRepository={datasetRepository} dataset={dataset} />
116+
)}
114117
</DropdownButton>
115118
)
116119
}

tests/component/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.spec.tsx

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,22 @@ describe('EditDatasetMenu', () => {
175175
cy.findByText('Deaccession is permanent.').should('exist')
176176
})
177177

178+
it('hides Deaccession button if current version is deaccessioned', () => {
179+
const dataset = DatasetMother.create({
180+
version: DatasetVersionMother.createDeaccessioned(),
181+
permissions: DatasetPermissionsMother.createWithAllAllowed(),
182+
locks: [],
183+
hasValidTermsOfAccess: true
184+
})
185+
186+
cy.mountAuthenticated(
187+
<EditDatasetMenu datasetRepository={new DatasetMockRepository()} dataset={dataset} />
188+
)
189+
190+
cy.findByRole('button', { name: 'Edit Dataset' }).click()
191+
cy.findByRole('button', { name: 'Deaccession Dataset' }).should('not.exist')
192+
})
193+
178194
it('clicks on the Delete button', () => {
179195
const dataset = DatasetMother.create({
180196
version: DatasetVersionMother.createNotReleased(),

0 commit comments

Comments
 (0)