Merge pull request #12492 from IQSS/12491-include-name-in-guestbook-responces-api

Include name in guestbook responses api

Author: landreev

doc/release-notes/12491-include-name-in-guestbook-responces-api.md

@@ -0,0 +1,2 @@
+## BUG ##
+Changed "userName" in guestbook response to "name" to match the parser in API GET /api/guestbooks/{guestbookId}/responses

src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java

@@ -31,6 +31,7 @@
 import edu.harvard.iq.dataverse.util.BundleUtil;
 import edu.harvard.iq.dataverse.util.DatasetFieldWalker;
 import edu.harvard.iq.dataverse.util.MailUtil;
+import edu.harvard.iq.dataverse.util.StringUtil;
 import edu.harvard.iq.dataverse.workflow.Workflow;
 import edu.harvard.iq.dataverse.workflow.step.WorkflowStepData;
 import jakarta.ejb.EJB;
@@ -426,7 +427,9 @@ public static JsonObjectBuilder json(GuestbookResponse gbResponse) {
             if (gbResponse.getDataFile().getGlobalId() != null) {
                 guestbookResponseObject.add("filePid", gbResponse.getDataFile().getGlobalId().asString());
             }
-            guestbookResponseObject.add("userName", gbResponse.getAuthenticatedUser() != null ? gbResponse.getAuthenticatedUser().getUserIdentifier() : "Guest");
+            if (!StringUtil.isEmpty(gbResponse.getName())) {
+                guestbookResponseObject.add("name", gbResponse.getName());
+            }
             if (gbResponse.getEmail() != null) {
                 guestbookResponseObject.add("email", gbResponse.getEmail());
             }

src/test/java/edu/harvard/iq/dataverse/api/FilesIT.java

@@ -4114,6 +4114,8 @@ public void testDownloadFileWithGuestbookResponse() throws IOException, JsonPars
                 .statusCode(OK.getStatusCode());
         JsonPath jsonPath = JsonPath.from(guestbookListResponses.body().asString());
         int totalCount = jsonPath.getList("data.responses").size();
+        assertTrue(totalCount > 0);
+        assertNotNull(jsonPath.getString("data.responses[0].name"));
 
         // Test Get Responses with pagination
         int pages = 4; // total should be 17. set to 4 pages