Skip to content

Commit 63db903

Browse files
committed
add guestbookId to request access error message
1 parent d9b59ca commit 63db903

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/main/java/edu/harvard/iq/dataverse/api/Access.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1655,7 +1655,7 @@ public Response requestFileAccess(@Context ContainerRequestContext crc
16551655
GuestbookResponse guestbookResponse = getGuestbookResponseFromBody(dataFile, GuestbookResponse.ACCESS_REQUEST, jsonBody, getRequestUser(crc));
16561656
if (ds.getGuestbook() != null && ds.getGuestbook().isEnabled()) {
16571657
if (ds.getEffectiveGuestbookEntryAtRequest() && guestbookResponse == null) {
1658-
return error(BAD_REQUEST, BundleUtil.getStringFromBundle("access.api.requestAccess.failure.guestbookAccessRequestResponseMissing"));
1658+
return error(BAD_REQUEST, BundleUtil.getStringFromBundle("access.api.requestAccess.failure.guestbookAccessRequestResponseMissing", List.of(ds.getGuestbook().getId().toString())));
16591659
} else if (guestbookResponse != null) {
16601660
engineSvc.submit(new CreateGuestbookResponseCommand(dvRequestService.getDataverseRequest(), guestbookResponse, guestbookResponse.getDataset()));
16611661
}

src/main/java/propertyFiles/Bundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2928,7 +2928,7 @@ access.api.requestAccess.failure.commandError=Problem trying request access on {
29282928
access.api.requestAccess.failure.requestExists=An access request for this file on your behalf already exists.
29292929
access.api.requestAccess.failure.invalidRequest=You may not request access to this file. It may already be available to you.
29302930
access.api.requestAccess.failure.retentionExpired=You may not request access to this file. It is not available because its retention period has ended.
2931-
access.api.requestAccess.failure.guestbookAccessRequestResponseMissing=You may not request access to this file without the required Guestbook response.
2931+
access.api.requestAccess.failure.guestbookAccessRequestResponseMissing=You may not request access to this file without the required Guestbook response for guestbookID {0}.
29322932
access.api.requestAccess.failure.guestbookresponseMissingRequired=Guestbook Response entry is required but not present ({0}).
29332933
access.api.requestAccess.failure.guestbookresponseInvalidOption=Guestbook Custom Question Answer not a valid option ({0}).
29342934
access.api.requestAccess.failure.guestbookresponseQuestionIdNotFound=Guestbook Custom Question ID {0} not found.

0 commit comments

Comments
 (0)