make itemReviewedCitation required #11747

Author: pdurbin

doc/sphinx-guides/source/_static/api/dataset-create-review.json

@@ -80,6 +80,12 @@
                 "typeClass": "controlledVocabulary",
                 "multiple": false,
                 "typeName": "itemReviewedType"
+              },
+              "itemReviewedCitation": {
+                "value": "dcid: dc/base/NCHS_BRFSS_Asthma",
+                "typeClass": "primitive",
+                "multiple": false,
+                "typeName": "itemReviewedCitation"
               }
             },
             "typeClass": "compound",

scripts/api/data/metadatablocks/review.tsv

@@ -4,7 +4,7 @@
 	itemReviewed	Item Reviewed	The item being reviewed		none	1		FALSE	FALSE	FALSE	FALSE	TRUE	TRUE		review	
 	itemReviewedUrl	URL	The URL of the item being reviewed		url	2		FALSE	FALSE	FALSE	FALSE	TRUE	TRUE	itemReviewed	review	
 	itemReviewedType	Type	The type of the item being reviewed		text	3		FALSE	TRUE	FALSE	FALSE	TRUE	TRUE	itemReviewed	review	
-	itemReviewedCitation	Citation	The full bibliographic citation of the item being reviewed		textbox	4		FALSE	FALSE	FALSE	FALSE	FALSE	FALSE	itemReviewed	review	
+	itemReviewedCitation	Citation	The full bibliographic citation of the item being reviewed		textbox	4		FALSE	FALSE	FALSE	FALSE	TRUE	TRUE	itemReviewed	review	
 #controlledVocabulary	DatasetField	Value	identifier	displayOrder												
 	itemReviewedType	Audiovisual		0												
 	itemReviewedType	Award		1												

src/test/java/edu/harvard/iq/dataverse/api/ReviewsIT.java

@@ -131,6 +131,8 @@ public void testCreateReview() {
 
         String itemReviewedTitle = "Percent of Children That Have Asthma";
         String itemReviewedUrl = "https://datacommons.org/tools/statvar#sv=Percent_Person_Children_WithAsthma";
+        // What's the right way to cite this data?
+        String itemReviewedCitation = "dcid: dc/base/NCHS_BRFSS_Asthma";
         String reviewTitle = "Review of " + itemReviewedTitle;
         String authorName = "Wazowski, Mike";
         String authorEmail = "mwazowski@mailinator.com";
@@ -212,7 +214,13 @@ public void testCreateReview() {
                                                                                 .add("typeClass",
                                                                                         "controlledVocabulary")
                                                                                 .add("multiple", false)
-                                                                                .add("typeName", "itemReviewedType")))
+                                                                                .add("typeName", "itemReviewedType"))
+                                                                .add("itemReviewedCitation",
+                                                                        Json.createObjectBuilder()
+                                                                                .add("value", itemReviewedCitation)
+                                                                                .add("typeClass", "primitive")
+                                                                                .add("multiple", false)
+                                                                                .add("typeName", "itemReviewedCitation")))
                                                         .add("typeClass", "compound")
                                                         .add("multiple", false)
                                                         .add("typeName", "itemReviewed"))))));