Skip to content

Commit f621538

Browse files
committed
ok to approve and merge anyway
1 parent 5d80425 commit f621538

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

doc/sphinx-guides/source/developers/making-releases.rst

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,17 @@ Create a new branch (any name is fine but ``prepare-next-iteration`` is suggeste
382382

383383
- modules/dataverse-parent/pom.xml -> ``<profiles>`` -> profile "ct" -> ``<properties>`` -> Set ``<base.image.version>`` to ``${parsedVersion.majorVersion}.${parsedVersion.nextMinorVersion}``
384384

385-
Create a pull request and put it through code review, like usual. Give it a milestone of the next release, the one **after** the one we're working on. Once the pull request has been approved, merge it. It should be the first PR merged of the next release.
385+
Create a pull request.
386+
387+
Wait for checks to complete. It's ok (even expected) for the following check to fail:
388+
389+
- main-integration-tests-workflow from container_integration_tests.yml
390+
391+
- If you see an error like ``Error: DOCKER> Unable to pull 'gdcc/base:6.12-noble-p7.2026.2-j21' : {"message":"manifest for gdcc/base:6.12-noble-p7.2026.2-j21 not found: manifest unknown: manifest unknown"} (Not Found: 404) [{"message":"manifest for gdcc/base:6.12-noble-p7.2026.2-j21 not found: manifest unknown: manifest unknown"} (Not Found: 404)]`` it's telling you that the Docker image can't be spun up for API testing because it doesn't exist yet. (The error above was just after the 6.11 release.) The image will exist once the pull request is approved and merged.
392+
393+
Put the pull request through code review, like usual, but make sure reviewers know it's ok to ignore the check above.
394+
395+
Give it a milestone of the next release, the one **after** the one we're working on. Once the pull request has been approved, merge it. It should be the first PR merged of the next release.
386396

387397
For more background, see :ref:`base-image-supported-tags`. For an example, see https://github.com/IQSS/dataverse/pull/10896
388398

0 commit comments

Comments
 (0)