In Memory File Zipping#1
Open
jachaos wants to merge 1 commit into
Open
Conversation
Replace the code to zip the files in memory instead of writting them to the disk first and some minor code adjustment and cleanup.
|
Much more elegant than my solution of programatically deleting the leftover files, nice work. Would be nice to see this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the code to zip the files in memory instead of writing them to
the disk first and some minor code adjustment and cleanup.
I was working on this code to submit files through the IDES Gateway, when creating several files or the same file multiples times it becomes bit messy having all these files in the destination folder, generating just the final zip file without the need of creating the "temporary" files first would produce a cleaner result. And the user can always find the files inside the .Zip file in case he wants to take a look to them.
Also moved the Creation of the Metadata XML file to the XMLManager class.