fix(infra): Fix Superset docker GitHub action (#172)

Refactored Docker image build workflow configuration to improve code
clarity by replacing an environment variable with explicit inline image
name construction across build and attestation steps, with no impact to
functionality.

Author: martyngigg

.github/workflows/docker-superset.yml

@@ -10,12 +10,16 @@ on:
     types: [opened, synchronize, reopened]
     paths:
       - "infra/container-images/analytics-data-platform-superset/Dockerfile"
+      - ".github/workflows/docker-superset.yml"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+  cancel-in-progress: true
 
 env:
   REGISTRY: ghcr.io
   ORG_NAME: isisneutronmuon
   IMAGE_NAME: analytics-data-platform-superset
-  FQ_IMAGE_NAME: ${{ env.REGISTRY }}/${{ env.ORG_NAME }}/${{ env.IMAGE_NAME }}
   PUBLISH: false
 
 jobs:
@@ -29,6 +33,8 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v5
+      - name: Compute fully qualified image name
+        run: echo "FQ_IMAGE_NAME=${{ env.REGISTRY }}/${{ env.ORG_NAME }}/${{ env.IMAGE_NAME }}" >> $GITHUB_ENV
       - name: Log in to the Container registry
         uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
         with:
@@ -42,14 +48,14 @@ jobs:
           context: infra/container-images/${{ env.IMAGE_NAME }}
           push: ${{ env.PUBLISH }}
           tags: |
-            ${{ FQ_IMAGE_NAME }}:${{ github.sha }}
-            ${{ FQ_IMAGE_NAME }}:latest
+            ${{ env.FQ_IMAGE_NAME }}:${{ github.sha }}
+            ${{ env.FQ_IMAGE_NAME }}:latest
 
       # This step generates an artifact attestation for the image, which is an unforgeable statement about where and how it was built.
       # See [Using artifact attestations to establish provenance for builds](/actions/security-guides/using-artifact-attestations-to-establish-provenance-for-builds)
       - name: Generate artifact attestation
         uses: actions/attest-build-provenance@v3
         with:
-          subject-name: ${{ FQ_IMAGE_NAME }}
+          subject-name: ${{ env.FQ_IMAGE_NAME }}
           subject-digest: ${{ steps.push.outputs.digest }}
           push-to-registry: ${{ env.PUBLISH }}

infra/container-images/analytics-data-platform-superset/Dockerfile

@@ -1,4 +1,4 @@
-ARG BASE_IMAGE=ghcr.io/isisneutronmuon/superset-fork:sha256-1f2019bd5a6ed81902d7c4035f0a363bceb10f60f5d9d98b4784857e2578506e
+ARG BASE_IMAGE=ghcr.io/isisneutronmuon/superset-fork:1a7712b054d5cf6f15f815e79eddb6f034a5ae49
 FROM ${BASE_IMAGE}
 
 LABEL org.opencontainers.image.source=https://github.com/ISISNeutronMuon/analytics-data-platform