chore(ansible): Fix Ansible playbook deprecation warnings (#318)

### Summary

Recent Ansible upgrades caused all old-style fact var injection to cause
deprecation warnings:

https://docs.ansible.com/projects/ansible/devel/porting_guides/porting_guide_13.html\#inject-facts-as-vars

Modify playbooks to use the new style.



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Updated internal deployment configuration to standardise how
environment variables are accessed across system setup tasks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: martyngigg

infra/ansible/roles/elt/tasks/elt_cron_tasks.yml

@@ -6,8 +6,8 @@
     path: "{{ elt_secrets_root_dir }}/{{ warehouse_name }}"
     state: directory
     mode: "u=rwx,g=,o="
-    owner: "{{ ansible_env['USER'] }}"
-    group: "{{ ansible_env['USER'] }}"
+    owner: "{{ ansible_facts['env']['USER'] }}"
+    group: "{{ ansible_facts['env']['USER'] }}"
 
 - name: Generate secrets
   become: true
@@ -16,8 +16,8 @@
     src: ./secrets/envvars.j2
     dest: "{{ elt_secrets_root_dir }}/{{ warehouse_name }}/envvars"
     mode: "u=r,g=,o="
-    owner: "{{ ansible_env['USER'] }}"
-    group: "{{ ansible_env['USER'] }}"
+    owner: "{{ ansible_facts['env']['USER'] }}"
+    group: "{{ ansible_facts['env']['USER'] }}"
 
 - name: Ensure cron logs directory exists
   ansible.builtin.file:

infra/ansible/roles/elt/tasks/main.yml

@@ -28,18 +28,18 @@
 # ---------- AWS S3 ----------
 - name: Ensure S3 configuration directory exists
   ansible.builtin.file:
-    path: "{{ ansible_env['HOME'] }}/.aws"
+    path: "{{ ansible_facts['env']['HOME'] }}/.aws"
     state: directory
     mode: "u=rwx,g=rx,o=rx"
 
 - name: Ensure S3 config file is absent
   ansible.builtin.file:
-    path: "{{ ansible_env['HOME'] }}/.aws/config"
+    path: "{{ ansible_facts['env']['HOME'] }}/.aws/config"
     state: absent
 
 - name: Ensure AWS configuration is present
   ansible.builtin.copy:
-    dest: "{{ ansible_env['HOME'] }}/.aws/credentials"
+    dest: "{{ ansible_facts['env']['HOME'] }}/.aws/credentials"
     content: |+
       [default]
       request_checksum_calculation = when_required
@@ -48,22 +48,22 @@
 # ---------- dlt ----------
 - name: Ensure dlt configuration directory exists
   ansible.builtin.file:
-    path: "{{ ansible_env['HOME'] }}/.dlt"
+    path: "{{ ansible_facts['env']['HOME'] }}/.dlt"
     state: directory
     mode: "u=rwx,g=rx,o=rx"
 
 - name: Generate .dlt/config.toml
   no_log: "{{ not (elt_enable_logs | default(False)) }}"
   ansible.builtin.template:
     src: dlt/config.toml.j2
-    dest: "{{ ansible_env['HOME'] }}/.dlt/config.toml"
+    dest: "{{ ansible_facts['env']['HOME'] }}/.dlt/config.toml"
     mode: "u=rwx,g=r,o=r"
 
 - name: Set shared ELT job variables
   ansible.builtin.set_fact:
-    elt_git_clone_dir: "{{ ansible_env['HOME'] }}/var/git"
-    elt_cron_root_dir: "{{ ansible_env['HOME'] }}/var/cron"
-    elt_cron_logs_root_dir: "{{ ansible_env['HOME'] }}/var/cron/logs"
+    elt_git_clone_dir: "{{ ansible_facts['env']['HOME'] }}/var/git"
+    elt_cron_root_dir: "{{ ansible_facts['env']['HOME'] }}/var/cron"
+    elt_cron_logs_root_dir: "{{ ansible_facts['env']['HOME'] }}/var/cron/logs"
 
 - name: Ensure cron scripts directory exists
   ansible.builtin.file: